Skip to content

Fix mobile Settings back navigation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AFR0011 merged 2 commits into from
Sep 17, 2026
Merged

Fix mobile Settings back navigation #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8fbc6
Fix mobile settings back navigation
AFR0011 Sep 17, 2026
f98c416
Cover mobile settings back navigation
AFR0011 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions e2e/settings-mobile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ test('settings navigation and local preferences remain usable offline on mobile'
await expect(general).toBeVisible();
await expect(settingsNavigation).toBeHidden();

await page.getByRole('link', { name: 'All settings', exact: true }).click();
await expect(settingsNavigation).toBeVisible();
await expect(page).toHaveURL(/\/app\/settings$/);

await settingsNavigation.getByRole('link', { name: /General/ }).click();
await expect(general).toBeVisible();
await expect(settingsNavigation).toBeHidden();

const method = general.getByRole('combobox', { name: 'Default payment method', exact: true });
await expect(method).toHaveValue('card');
await method.selectOption('cash');
Expand Down
3 changes: 2 additions & 1 deletion src/components/SettingsWorkspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,7 @@ export default function SettingsWorkspace() {
{activeSection ? (
<Link
href="/app/settings"
onClick={() => setActiveSection(null)}
className={cn(
'mb-3 inline-flex min-h-11 items-center gap-2 rounded-lg px-1 text-sm font-semibold text-accent md:hidden',
focusVisibleRing
Expand Down Expand Up @@ -963,4 +964,4 @@ function SyncDetailRow({ label, value }: { label: string; value: string }) {
function formatSyncTimestamp(value: string | null | undefined) {
if (!value) return 'Never';
return new Date(value).toLocaleString();
}
}