feat(worstcase): add report_individual flag for per-record member_prob#461
Merged
Conversation
Merged
This was
linked to
issues
May 26, 2026
Contributor
|
This still needs clean up? There are conflicts to be resolved; the PR title scopes it to "worstcase" yet introduces a variety of changes to tests for other attacks, the introduction of a constants module, a meta attack example, and changes to the readme, etc. The initial comment indicates that this PR is stacked on top of #441, but that appears to now be merged, so why are there still so many changes unrelated from the description? |
217474f to
e769ea1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 27 27
Lines 3436 3439 +3
=======================================
+ Hits 3424 3427 +3
Misses 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rpreen
approved these changes
Jun 11, 2026
Signed-off-by: Jessica Ikechukwu <Jessica.Ikechukwu@uwe.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #452
adds a
report_individualflag toWorstCaseAttack(defaultFalse)when set to True, each repetition's metrics dict gets an
"individual"key holding per recordmember_probandmember, matching howLIRAAttackandQMIAAttackalready report per record resultsthis lets
MetaAttackfold worstcase into its vulnerability matrix later, that wiring is a separate follow up