Repository navigation
Support explicit disconnected q paths in pySED 3.0 - #101
Merged
Tingliangstu merged 2 commits intoNov 4, 2026
Merged
Conversation
Tingliangstu
merged commit Nov 4, 2026
dba70da
into
codex/pysed-3.0-architecture
10 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Support explicit disconnected paths with
q_path_name = GXU|KGL(quotes optional) andnum_qpaths = 4. This computes Gamma-X-U and K-Gamma-L, without generating the unintended U-K segment.|specifies connectivity, not degeneracy or symmetry equivalence.Preserve each sampled segment's column range in
.Q_distances_and_labelsand render segments independently for total and partial SED. Existing files without this metadata remain readable.Use requested Cartesian path lengths for distances and labels; report unsampled endpoints and retain empty segments as gaps rather than silently converting them into breaks.
Update the Si input, its path instructions, the input template, and manual. Recalculation is required after changing path connectivity.
Print the full path and explicit terminal break notices, e.g.
Path break : U|K (no connecting segment), between path groups.Benefit
The Si path definition now stays the same for 20, 40, and 41 repeats. Previously, U-K disappeared only when no commensurate points existed on that segment; 40 repeats produced an unintended connecting segment. Saved topology also prevents plotting from interpolating between distinct endpoints at a break.
Related to #36. This addresses the identified path-definition issue; it does not claim a rerun of the original reported MD trajectory.
Validation
WSL existing
pysedenvironment: full suite 123 passed, 344 subtests passed, including CuPy/GPU tests.Windows focused parser/path/output/plot/CLI suite: 54 passed.
Windows full suite: 120 passed, 1 skipped, 2 failed. Both failures reproduce on unchanged base
1e99ed9: text-file CRLF byte-offset assertion and persistent-worker native thread-limit assertion. No unrelated fixes included.Strict Sphinx HTML build (
-W --keep-going): passed.Visually inspected saved/reloaded synthetic spectra for 20, 40, and 41 repeats. Deliberately unequal peaks on either side of U|K stay disconnected; missing commensurate endpoints remain unfilled. Regression tests also cover partial SED, multiple breaks, malformed inputs, empty and single-point segments, and historical output loading.
Terminal-output follow-up: 15 path tests passed; directly checked the break position, multiple breaks, continuous paths, and quiet mode.