Repository navigation
Add HWPX editing/saving and free-runner E2E release gates - #1
Merged
Merged
Conversation
|
Review these changes at https://app.gitnotebooks.com/ATLKR/OpenGeul/pull/1 |
…dows build graphs
Owner
Author
|
Continuation checkpoint (candidate
Full required candidate checks: https://github.com/ATLKR/OpenGeul/actions/runs/37389896622 . These are still running; the PR remains draft. The isolated native probe reuses the prior executable to validate the harness only and is not counted as candidate release evidence. All original 52 UI executions and MSIX installation checks remain required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Adds genuine HWPX editing/saving to the pinned HOP Windows app, both HWP/HWPX Save As formats, native staged writes with revision/external-change validation, and preservation of edits made during asynchronous saves. Existing HWP persistence is retained. This is not a filename-only conversion.
Required release gates
Standard runners only: two Windows native UI environments (14 scenarios each), Chromium/Firefox/WebKit (8 scenarios each), and ephemeral test-sign/install/association/uninstall validation of a COPY of the unsigned MSIX. Independent ZIP/XML validation, bounded evidence, and no skipped required tests or automatic flaky retries. PRs do not publish. No fonts, private documents, signing keys or app test backdoors are shipped.
Repairs made during actual verification
Current evidence and limits
Final candidate:
c9094979e86ffeab5b5db1e38fd47e2a0c76ae43.Full required run: https://github.com/ATLKR/OpenGeul/actions/runs/37391332552 . Policy run
37391331550passed. The source-built WASM and all three browser E2E jobs have passed; the final Windows build/native/install gates are still running at this checkpoint. This remains a draft and must not be merged until the complete required run succeeds.The isolated native harness probe
37391088827passed all 14 scenarios on BOTH windows-2022 and windows-2025, including actual HWPX editing/saving, HWP conversion, cancellation, multi-window behavior and corrupt-file recovery. That probe reuses the previous candidate binary and verifies harness repairs only; it is NOT substituted for final-candidate package/E2E evidence.Local Python policy/automation unit suite: 51 passed. Node save-format/composition suite: 22 passed. Earlier native/frontend regression results and limitations remain in the repair ledger. HWPX XML validation has not been weakened, failing input has not been normalized away, and all 52 required UI executions remain enabled.
Remaining product limits
Real OS IME composition, real printers, complex third-party documents, all font-license rights, trusted distribution signing and Microsoft Store certification are not established by these automated tests. Autosave/recovery and LibreOffice are not included. OpenGeul-owned changes remain MIT with upstream notices preserved. HOP keyboard/toolbar follow-ups are isolated in #2.