Skip to content

Backport HOP printable-key fix and add persistent toolbar label preference - #2

Merged
ATLKR merged 3 commits into
mainfrom
work/hop-followups
Oct 6, 2026
Merged

ATLKR merged 3 commits into
mainfrom
work/hop-followups

Conversation

@ATLKR

@ATLKR ATLKR commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Scope

This is a separate, stacked follow-up to #1. Retarget to main after #1 is verified and merged; do not merge this into the HWPX branch.

  • Adapt HOP PR golbin/hop#101, by FMsongX2 at f9bbe8dc66172a1959af1e388e6c28a5b597c5a6, to stop unmodified printable p/P from being swallowed by a global shortcut. Keeps Ctrl/Cmd+P and function keys. Addresses the reports in 대소문자 상관없이 영문 P가 안 써짐. golbin/hop#95 and #100 downstream, without claiming upstream acceptance.
  • Add an opt-in toolbar-label visibility preference for 라벨 끄기 기능 추가 요청 golbin/hop#97. Default labels remain visible; icon buttons retain accessible names; the preference persists locally without changing the document.
  • Apply these fixes to BOTH the source-built browser frontend and the Windows application, not only a development probe.
  • Preserve all original HWPX/native/browser tests and add two E2E scenarios per environment: 16 on each Windows image and 10 on each browser (62 UI executions total), plus MSIX installation/associations/uninstall. Every required gate blocks release on failure or skipped tests.
  • Retain original MIT notices and ship explicit backport attribution in THIRD_PARTY_NOTICES.md. No font binaries or private documents are added.

Evidence and boundaries

  • Earlier isolated production-source probe 37390568484 at 47979e7 passed Chromium, Firefox and WebKit, 10 scenarios per browser, plus the keyboard/preference unit tests. This is not proof of the final Windows package.
  • Four new build-integration regression tests were observed failing before integration; all 55 local Python tests now pass. YAML/shell syntax and diff checks passed.
  • The final candidate builds and all 62 UI gates still need to run. This remains a draft until that evidence is green.
  • docs/UPSTREAM_TRIAGE.md records other reports that still need reproduction; this PR does not claim to fix table clipping, printing fidelity, encrypted documents or ARM64 packaging.

@gitnotebooks

gitnotebooks Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review these changes at https://app.gitnotebooks.com/ATLKR/OpenGeul/pull/2

@ATLKR
ATLKR changed the base branch from work/hwpx-e2e to main October 6, 2026 01:28
@ATLKR
ATLKR marked this pull request as ready for review October 6, 2026 01:29
@ATLKR
ATLKR merged commit 642b7a0 into main Oct 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant