Repository navigation
Backport HOP printable-key fix and add persistent toolbar label preference - #2
Merged
Merged
Conversation
… toolbar preference
…uilds and all E2E release gates
|
Review these changes at https://app.gitnotebooks.com/ATLKR/OpenGeul/pull/2 |
This was referenced Oct 6, 2026
ATLKR
marked this pull request as ready for review
October 6, 2026 01:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This is a separate, stacked follow-up to #1. Retarget to
mainafter #1 is verified and merged; do not merge this into the HWPX branch.f9bbe8dc66172a1959af1e388e6c28a5b597c5a6, to stop unmodified printablep/Pfrom being swallowed by a global shortcut. Keeps Ctrl/Cmd+P and function keys. Addresses the reports in 대소문자 상관없이 영문 P가 안 써짐. golbin/hop#95 and #100 downstream, without claiming upstream acceptance.Evidence and boundaries
37390568484at47979e7passed Chromium, Firefox and WebKit, 10 scenarios per browser, plus the keyboard/preference unit tests. This is not proof of the final Windows package.docs/UPSTREAM_TRIAGE.mdrecords other reports that still need reproduction; this PR does not claim to fix table clipping, printing fidelity, encrypted documents or ARM64 packaging.