feat(od-ontology): pull namespace inheritance + richer DOLCE classifier from hydrators#15
Merged
AdaWorldAPI merged 1 commit intoJun 22, 2026
Conversation
…er from hydrators
Phase-2 continued (per REPATRIATION-FRAME.md): pulled the Layer-1 hydrator
content from `lance_graph_ontology::hydrators::{odoo, dolce_odoo}` — namespace
inheritance + cascade edge whitelist + richer DOLCE classifier.
THE namespace-level "Odoo inheriting classes" declaration:
- `ODOO_BUNDLE_ID` (0x0002, v1) inherits from `ODOO_INHERITS_FROM_FIBOFND_V1`
(FIBO Foundations, 0x0007, v1). Per-class equivalentClass rows in ODOO_SEED
are the instances; these constants are the literal declaration.
- `ODOO_NAMESPACE_IRI = "https://ada.world/onto/odoo#"`.
- `ODOO_EDGE_WHITELIST` — the four cascade RDF predicates (rdfs:subClassOf,
owl:equivalentClass, rdfs:subPropertyOf, owl:equivalentProperty). Per the
compiler-AST frame: these ARE the AST-edge types the symbol-table follows.
- `ODOO_TTL_SOURCES` — informational list of the three TTL files the upstream
harvest produces.
Richer DOLCE classifier (merged from two disagreeing lance-graph classifiers):
- Pulled the 12-suffix PERDURANT list (was 8): added .message, .activity,
.attendance, .transition, .event, .log, .history, .transaction, .scrap.
- Added a separate QUALITY suffix list: .tag, .type, .groups, .group, .category
(was just uom.*).
- Added richer ABSTRACT: .template, .settings, .config, .policy, .rule, .formula
(on top of existing .tax, fiscal.position, reconcile.model, payment.term,
.pricelist*).
- Endurant special-cases (product.template, account.account.template) preserved
to maintain ODOO_SEED agreement.
- Accepts prefixed IRIs (`odoo:` or full `https://ada.world/onto/odoo#`).
Documented "two-classifier disagreement" table — the two lance-graph
classifiers disagree on:
- `.tax` (alignment.rs Abstract, hydrator Quality) → kept Abstract here
- `.tag` / `.type` / `.group` / `.category` (alignment.rs sweeps to Endurant
via fallback, hydrator Quality) → kept Quality here
- `.template` (alignment.rs Endurant via product.*, hydrator Abstract w/
product.template special-case) → kept Abstract w/ TWO special-cases
- `hr.*` (alignment.rs Unknown, hydrator Endurant by default) → kept Unknown
- Default (alignment.rs Unknown, hydrator Endurant) → kept Unknown
- Phase-3 OGAR-side will canonically resolve.
REAL findings surfaced while writing the cross-validation:
1. The hydrator's .config rule had a misleading comment claiming to match
`*.config.settings` but did not — `res.config.settings` ends with
`.settings`, not `.config`. Added .settings to the Abstract list to catch
the real Odoo settings shape.
2. The hydrator's .group rule similarly claimed to match `res.groups` (plural)
but did not. Added .groups (plural) to the Quality list.
Both hydrator bugs were silent because the hydrator's own tests don't
check `res.groups` or `res.config.settings`.
11 new pins in tests/alignment_pin.rs: prefixed-IRI handling, strip_odoo_prefix
roundtrip, new Perdurant/Quality/Abstract suffix rules, Endurant special-cases,
the .tax disagreement marker, namespace IRI / bundle ID / FIBO inheritance,
edge whitelist (two load-bearing + two property variants), TTL sources list.
Additive only — lance-graph hydrators untouched (still the duplicate to be
subtracted in a later phase). 150+ test results across the suite pass:
39 lib + 27 alignment-pin + 10 corpus-pin + 13 typed-lift + 10 ogar-parallel +
9 ogar-convergence + 7 bin + others. clippy on my code clean; fmt-clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 23, 2026
AdaWorldAPI
pushed a commit
that referenced
this pull request
Jul 7, 2026
All five lenses reported; 3-meta synthesis consolidated: R1 HOLD->RESOLVED (5b45170) · R2 CATCH-LATENT x2 (queued) · R3 TARGETS-CORE + triple.rs VIOLATION (Q1, THE next refactor) · R4 3 OPPORTUNITY / 3 WORTH-EXPLORING / 0 DROP · R5 OVERCLAIMED -> core gap RESOLVED same-hour (real 55-file account addon compiled + verbatim account_move.py fused). One reviewer premise corrected by synthesis: L6 SPOG IS ruled (operator 2026-07-06); what is missing is the lance-graph ledger paperwork + the attribute->byte-position assignor, not the ruling. Queue Q1-Q9 with sizes + owners recorded in docs/COUNCIL-5+3-2026-07-07.md: triple.rs upstream migration, group_functions EmittedBy arm (smallest highest-leverage ruff diff), ledger appends x3 repos, od-posting re-architecture off SurrealQL vocabulary, mint relocation + odoo_actions authority table, guard-classifier convergence, 5.1%-tail ownership, carrier asks (#11/#15/#17 + stored verify).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase-2 continued (per
REPATRIATION-FRAME.md— frame #12, schema #13,alignment table #14). Pulled the Layer-1 hydrator content from
lance_graph_ontology::hydrators::{odoo, dolce_odoo}into odoo-rs'salignmentmodule — three concrete things land:1. The literal "Odoo inheriting classes" declaration
This IS the namespace-level statement that "Odoo's classes inherit from FIBO
Foundations" — the literal pattern your original complaint named ("instead of
inheriting classes"). The per-class
owl:equivalentClassrows inODOO_SEEDare the instances of this inheritance; these constants are the
declaration.
2. The cascade edge whitelist (compiler-AST symbol-table predicates)
Per the compiler-AST frame (#13): these ARE the AST-edge types the
symbol-table follows during transitive resolution.
rdfs:subClassOfcarriesOdoo's own facet subsumption;
owl:equivalentClassis the route into FIBO /schema.org / QUDT slots (the
ODOO_SEEDrows resolve through this).3. The richer DOLCE classifier (merged from TWO disagreeing lance-graph classifiers)
.move,.move.line, …).message,.activity,.attendance,.transition,.event,.log,.history,.transaction,.scrap)uom.*only.tag,.type,.group,.category,.taxuom.*+.tag,.type,.groups,.group,.category.tax,fiscal.position,reconcile.model,payment.term,.pricelist*.template,.config,.policy,.rule,.formula.settingsproduct.*product.templateonlyproduct.templateANDaccount.account.templateUnknownEndurantUnknown(surfaces gaps; consumer decides)Plus IRI handling — accepts bare names,
odoo:prefix, or fullhttps://ada.world/onto/odoo#IRI.Two-classifier disagreement (deliberate reconciliations)
lance-graph hosts two disagreeing DOLCE classifiers; the doc table on
dolce_odoorecords every reconciliation choice with rationale, including.tax(kept Abstract; the hydrator says Quality — Phase-3 OGAR-side decides),hr.*(kept Unknown — the alignment seed and the hydrator disagree, surfacingthe gap rather than picking one), and the default (kept Unknown — hiding gaps
behind an Endurant fallback obscures the surface).
Real findings surfaced via cross-validation
Two silent bugs in the hydrator the cross-validation caught:
.configrule had a misleading comment claiming to match*.config.settingsbut it doesn't —
res.config.settingsends with.settings, not.config.Added
.settingsto the Abstract list to catch the real Odoo shape..grouprule similarly claimed to matchres.groups(plural — thecanonical Odoo class) but didn't. Added
.groupsto the Quality list.The hydrator's own tests didn't surface either bug because they don't test
the actual class names the comments claim to match.
Tests
150+ test results green across the suite: 39 lib + 27 alignment-pin (was
14 in #14 → 13 new pins) + 10 corpus-pin + 13 typed-lift + 10 ogar-parallel +
9 ogar-convergence + 7 bin + others. clippy on my new code clean. fmt-clean.
11 new pins in
tests/alignment_pin.rs:odoo:/ full namespace)strip_odoo_prefixroundtripproduct.template,account.account.template).taxdisagreement marker (documented Abstract choice)Frame status
Builds on the consistent across-PR governance:
Remaining Phase 2: the
odoo_blueprint/{l1..l15}.rs14K-LOC pull (bounded perfile). Phase 3 (push empowerments to OGAR): the
OwlPivotshape, thesuffix-classifier algorithm, the
family_default_style → StyleClusterinheritance, and resolving the documented disagreements (especially
.tax).