schema: add index_filter to get_interface_statistics (#272) - #387
Draft
AdamRickards wants to merge 1 commit into
Draft
AdamRickards wants to merge 1 commit into
AdamRickards wants to merge 1 commit into
Conversation
Adds method-level index_filter '^\d+/\d+$' to get_interface_statistics, mirroring get_optics, aiming for physical-only rows on all protocols. Offline (tested): the engine applies method index_filter only in intent resolution when index is a list; the read (egress) path does not read it. A fixture with cpu/vlan ifTable rows returns the same rows before and after this change. Live sidecar proof: untested (pending). Schema YAML only. Draft for sidecar live proof; do not merge. Related #272
Owner
Author
|
Sidecar live proof —
Result: fail vs #272 floor (all protocols physical-only). Live matches offline: method Draft; do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for sidecar live proof; do not merge.
Adds method-level
index_filter: '^\d+/\d+$'toget_interface_statistics(schema YAML only), aiming for physical-only rows across protocols (#272).Offline (tested): method
index_filteris applied only in_resolve_intentwhenindexis a list;_pipeline_egress/_shape_table_outputdo not read it. An OfflineHIOS fixture withcpu/*andvlan/*ifTable rows returns the same rows before and after this change, so offline shows the filter is not applied on reads.Live (untested, pending): sidecar
get_interface_statistics.readmops/snmp/ssh row counts and parity_diffs on this head vs main.Related #272