Options for moving Upgrade Icon#499
Open
legowxelab2z8 wants to merge 3 commits intoAdiAddons:masterfrom
Open
Conversation
Added options to the Item section that has other options for how item buttons are displayed like quest indicator and quality highlight.
Move UpdateUpgradeIcon to ItemButton.lua Call UpdateUpgradeIcon in the OnEnabled in core.lua for handling profile changing Set the Setter function on the option group that is inherited by the Anchor and Offset options instead of using a setter for each option. Fix Whitespaces Remove the whitespace in Options.lua to minimize changes with the master branch Add a whitespace in Core.lua to minimize changes with the master branch Fix whitespaces Fix whitespaces ../core/Core.lua:174 ../config/Options.lua:668 Actually fix whitespaces this time perhaps it is time I installed a linter...
legowxelab2z8
force-pushed
the
UpgradeIcon
branch
from
634acd4 to
07ef0ed
Compare
Change IterateActiveObjects to IterateAllObjects. Since the buttons are already created but inactive they still need to be updated since they will be reused for new items in your bags and the icon needs to be updated.
|
Also seems to work well, and works with no issues that I've found with #496. |
This was referenced Dec 3, 2020
Closed
|
Any further issues? Testing for this pull has gone well and haven't seen any issues. |
Alyred
reviewed
Mar 20, 2021
Alyred
left a comment
Alyred
left a comment
There was a problem hiding this comment.
After manually integrating these ( as in #496 ) the code still functions fine without any conflicts with 1.9.23-3alpha, just some new line locations.
No issues or code conflicts noted with #496 or #522, other than all three of these pulls languishing long enough that code as drifted in the meantime.
|
Edit: Not a huge issue anymore since AdiBags 1.9.49 moved the itemlevel text to the bottom left instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds options for moving the Upgrade Icon.
This feature was in #206 but was omitted in #496
The options are included in the main options under Items with the rest of the item options (quest indicator, quality highlight). Most of the changes are made to widgets\ItemButton.lua
If implemented these options will share localization with #496