Update sas-related images - #3
Merged
Merged
Conversation
… and organized the additional installs.
… and removed ROS_DOMAIN_ID. Added apt-get update and cleanup commands to Dockerfile.
Collaborator
|
Murilo M Marinho (@mmmarinho) thanks! sounds good to me. Please let me know when you finish the modifications. Kind regards, Juancho |
Juan José Quiroz Omaña (juanjqo)
marked this pull request as ready for review
April 1, 2026 15:01
Juan José Quiroz Omaña (juanjqo)
approved these changes
Apr 1, 2026
Juan José Quiroz Omaña (juanjqo)
left a comment
Juan José Quiroz Omaña (juanjqo)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Murilo M Marinho (@mmmarinho) it looks good for me.
Juan José Quiroz Omaña (juanjqo)
merged commit Apr 1, 2026
984546a
into
Adorno-Lab:main
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Juan José Quiroz Omaña (@juanjqo),
Some ideas to reduce the size of dependent images:
dqrobotics/Dockerfileaddapt-getupdates at the beginning at the file.dqrobotics_ros_jazzy/Dockerfileaddapt-getupdates at the beginning at the file and removeROS_DOMAIN_ID.dqrobotics_ros_jazzy_sas/Dockerfileremove it because we havemurilomarinho/sas.Some ideas to keep in mind if one or more of these are useful.