Repository navigation
fix(install): print node up/down in the quick start - #1918
khaliqgant wants to merge 5 commits into
Conversation
The installer's quick start printed `agent-relay up --background` and `agent-relay down` after both moved under `node`; `up` fails with "unknown command 'up'" and `down` prints the top-level help. A test now resolves every quick-start command against the real command tree. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe installer selects Quick Start ChangesQuick Start commands
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Quick Start commands are selected by the documented version threshold, and no supported pin incompatibility is established. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkResolution Add the required Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the commands in a row Comment |
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21017cfa24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Add an [Unreleased - Patch] Fixed entry for the installer's node up/down commands, and let the quick start test skip <placeholders> and words after a leaf command so a future positional value does not fail it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
CI note on head
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bbd4e95e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Re-run result: |
… pinned installs The node command group arrived in 9.2.2, so an AGENT_RELAY_VERSION pin to an older release would be told to run commands it lacks. The quick-start test now executes print_usage for latest, 9.2.1 and later versions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bug
After installing,
install.shprints:Both commands moved under
node.agent-relay upfails witherror: unknown command 'up', andagent-relay downprints the top-level help. A new user's first command fails. This was reported as a known issue on our agent's live knowledge page.Fix
agent-relay node up --backgroundandagent-relay node down;agent-relay statusis unchanged.bootstrap.test.ts: it extracts everyagent-relay …line fromprint_usageand resolves each word againstcreateProgram()'s real command tree. It fails on the old script (agent-relay up --background: no "up" command) and passes with the fix, so the quick start can't drift from the CLI again.Note:
node upon 11.3.0 and earlier printed the workspace key; the installer installs the current 13.x, which masks it.🤖 Generated with Claude Code
Note
Low Risk
Installer messaging and tests only; no runtime broker or auth behavior changes.
Overview
Fixes post-install Quick Start text so it matches the current CLI:
agent-relay node up --backgroundandagent-relay node downinstead of removed top-levelup/downthat error on first run.install.shpicks the printed form fromAGENT_RELAY_VERSION: pinned releases before 9.2.2 still show the legacyagent-relay up/downlines.Adds regression coverage in
bootstrap.test.tsthat runsprint_usagefor several versions and walks each suggested command againstcreateProgram(), so installer hints cannot drift from real subcommands again.Reviewed by Cursor Bugbot for commit 7279644. Bugbot is set up for automated code reviews on this repo. Configure here.
Agent Relay sessions
claudesession1e2adfbe· opened viagh pr create· last active 2026-10-08