Repository navigation
skill(orchestrating-agent-relay): subscribe live PR owners on Agent Relay 12.4 - #108
khaliqgant wants to merge 3 commits into
Conversation
Audit the orchestrating skill against Agent Relay 12.4 and make subscribing the live PR-owner agent to the PR's GitHub provider resource the durable default. Cover rebinding after respawn, unsubscribe/release hygiene, no duplicate writable helper subscriptions, and verifying actual event delivery. Salvage still-valid #56 workflow lessons (idle detection, per-turn interactive spawn, LLM-as-oracle, repair-step counterweight) into writing-agent-relay-workflows.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
[relay-subscribe-probe] Wake check for @skills-orchestration-audit-grok on /github/repos/AgentWorkforce/skills/pulls/108/** — please ignore; verifying provider event delivery. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0ecd77a76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…12.4 delivery The PR glob wakes events whose resource_ref is that PR even when the inventory file lives under /reviews or /comments. Per-turn interactive spawn only beats idle detection when each turn itself finishes inside the window.
…s, checks, comments Codex P1: the single /pulls/<n>/** command did not match the promised wake set. Subscribe the owner to the adapter nested reviews/status globs plus GitHub issue-comment paths as well.
…ant lessons Retarget pass over the folded-in #108 content plus the open review findings on this PR. Deprecation (v1 -> v2): - writing-agent-relay-workflows 1.6.25 -> 2.0.0. DEPRECATED banner at the top of SKILL.md and a rewritten frontmatter description, so a skill listing shows the deprecation and the pointer to writing-relayflows without opening the file. All v1 reference material kept intact below. - migrating-persona-to-relayflow 1.0.0 -> 1.1.0. Same short pointer, and corrects the stale "v2 is still under construction" bullet — v2 ships today as @relayflows/surface / @relayflows/sdk, CLI `flows`. - agent-relay-starter collection 1.1.0 -> 1.2.0: writing-relayflows is now the required workflow-authoring skill; the v1 skill drops to optional. Retargeted out of the v1 skill into relay-80-100-workflow 2.0.0 -> 2.1.0 (the v2 validation skill), because both lessons are about the ladder, not about either engine's syntax: - do not add a repair step to a gate with no agent-fixable failure surface - grade computable things in a deterministic step, never with an LLM Both also get an anti-pattern row. The idle-detection / per-turn spawn material stayed in the v1 skill: idleThresholdSecs, preset and interactive channel agents have no v2 equivalent. Review findings resolved in relay-80-100-workflow: - "None of that is reachable by a gate" was too categorical; the residue gate later in the skill shows the opposite - the re-record example used `/* same command */`, which does not compile; the command is now a named const reused by both record calls - require-green now writes BLOCKED_NO_COMMIT before its non-zero exit, so the artifact the skill requires actually exists when acceptance is red - `npx vitest run` -> `npx --no vitest run`, with a note to run tools from the project's own lockfile (CWE-494) writing-relayflows 1.2.0 -> 1.3.0: reconciles "always gate an agent step" with relay-80-100-workflow's "enforce after the agent, not on it" — the two skills contradicted each other. Where the check goes now depends on whether a red result should stop the run or become repairable work. Root agent-workforce-skills 1.5.0 -> 1.6.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Folded into #107 — closing this oneCombining the two into a single PR, per the user. This branch is merged into Why #107 was the base rather than this one. It is the larger piece ( What carried over unchanged. Everything in What changed about the
Review threads on this PR. All three ( Follow #107 from here. Neither PR is being merged — that call is the user's. 🤖 Generated with Claude Code |
Summary
Audit
skills/orchestrating-agent-relay/SKILL.mdagainst the Agent Relay 12.4 CLI (agent-relay --version→ 12.4.0) and make this the durable orchestrator default:The moment a worker opens or owns a PR, subscribe that live PR-owner agent to the PR's GitHub provider resource so review comments, pushes, check changes, and discussion wake it:
Why this belongs in the orchestrator skill
Provider wakes are not a workflow-YAML concern here. Headless teams that ship PRs with
node/fleetworkers currently poll inbox/ghand miss review traffic while idle. 12.4integration subscribeprovisions a Relay inbound webhook, a Relayfilepath_globsubscription, and a binding keyed by(provider, resolved path glob). That is the orchestrator's job the instant a PR number exists.What the skill now requires
--to @Owner), not a helper and not a shared channel.Implementer2,--delete-agent) does not inherit the old route; re-subscribe. Same-name release without delete keeps the binding — confirm--liststill points at@Owner.(github, glob)replaces the owner's route (create-first). Reviewers read via git/ghor channel traffic.webhookId/webhookSubscriptionId/ binding disappeared, thenfleet release. Do not tear down a working binding before a replacement lands.--list+ webhook inventory + livefleet agent listare necessary but not sufficient. A real GitHub event must arrive as a Relay message fromgithubwith a Relayfile path under that glob (check_inbox/list_messages).node deadlettersmust not hold it. Cloud/Nango 2xx is not proof.12.4 CLI corrections (validated against
--help)integration subscribe/unsubscribe/subscribe --listare the provider-binding surface.integration subscription listis a different Relay workspace-event API.integration webhook createtakes<channel>(inbound). The older<url> --eventshape in public docs is stale.fleet spawn/fleet release/fleet agent listare the control-plane lifecycle commands;node agent *remains local-broker.muse,grok,opencode,devin(plus the existing CLIs).droidstays high-risk for delegation.node deadlettersis the failed-delivery inspection path.Relationship to PR #56
Inspected #56 (
skill(writing-agent-relay-workflows): lessons from multi-CLI game test).That PR edits
writing-agent-relay-workflows, not this skill. After the 12.4 audit:writing-agent-relay-workflows(still absent on main 1.6.24).idleThresholdSecsidleThresholdSecsexists on@relayflows/coreWorkflowBuilder.This replacement PR therefore supersedes #56: unique surviving lessons are preserved in
writing-agent-relay-workflows1.6.25; the orchestrating skill is the 12.4 operational surface #56 never covered.Test plan
orchestrating-agent-relayskill end-to-end.agent-relay12.4--helpfornode,fleet(spawn/list/release/agent list),integration(subscribe/unsubscribe/webhook/subscription),observer,message,agent.provider-subscriptions.mdx, andtests/e2e/github-subscriptions/README.mdfor binding/replacement/delivery semantics.--help(all OK).prpm.jsonparses; package files exist; descriptions ≤500 chars; no duplicate package names.@skills-orchestration-audit-grokto/github/repos/AgentWorkforce/skills/pulls/<this>/**and verify webhook binding + delivery evidence.Note
Low Risk
Documentation and skill version bumps only; no runtime or application code changes.
Overview
Bumps
orchestrating-agent-relayto 2.4.0 (and package metadata/README) to document Agent Relay 12.4 headless orchestration: when a worker owns a PR, subscribe that live agent viaintegration subscribe githubto four Relayfile globs (PR body, reviews, status, issue comments), with rebinding after respawn, helper/no-duplicate-binding rules, unsubscribe-before-release hygiene, and delivery verification (real GitHub events in inbox, not just--list).The skill also expands quick reference and protocol for
fleet agent list/fleet release,node deadletters, corrected integration CLI surfaces (subscribe --listvssubscription list, inboundwebhook create), and extra spawn CLIs; release flow now requires unsubscribing owned resources first.writing-agent-relay-workflowsgoes to 1.6.25 with workflow-authoring fixes salvaged from superseded work: when not to add repair steps, per-turn interactive spawn vs long waits,idleThresholdSecs/ ~30s idle detection vs “wait for channel event”, and new common-mistake rows (LLM-as-oracle, pointless repair gates).Reviewed by Cursor Bugbot for commit 1967690. Bugbot is set up for automated code reviews on this repo. Configure here.
Agent Relay sessions
claudesessiona32d0191· contributor · rangh prcommands · last active 2026-09-21