Consolidate footer.css imports across page-shell stylesheets - #168
Merged
Conversation
The footer rebuild (94d0940) put all its rules in footer.css and imported it only from backdrop.css, on the assumption that "every page that renders <Footer /> already imports backdrop.css." That was never true: only demo/index.astro, live/index.astro, and BlogPostLayout.astro import backdrop.css. The home page and everything on docs.css (docs, blog index, all how-it-works pages, vs/vector-rag) import landing.css or docs.css directly and never got footer.css at all, so the footer rendered with zero grid/flex/spacing rules — a single stacked column of concatenated links. Import footer.css directly from landing.css and docs.css, the same way backdrop.css already does, so every page shell carries it without a fourth per-page import to forget. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AkashGoenka
force-pushed
the
claude/coldstartmcp-footer-bug-i89aub
branch
from
September 7, 2026 10:24
98455fe to
c280a61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
footer.cssimports from being solely inbackdrop.cssto being imported directly by all three page-shell stylesheets (landing.css,docs.css, andbackdrop.css). This ensures every page that renders the<Footer/>component has its styles available without relying on a single indirect import path.Changes
@import './footer.css'statements to ensure footer styles are available on all pages using these stylesheetsImplementation Details
footer.csstwice, but this is harmless since the rules are identical<Footer/>should have its styles available through the stylesheet it already imports🤖 Generated with Claude Code