Skip to content

Consolidate footer.css imports across page-shell stylesheets - #168

Merged
AkashGoenka merged 1 commit into
mainfrom
claude/coldstartmcp-footer-bug-i89aub
Sep 7, 2026
Merged

Consolidate footer.css imports across page-shell stylesheets#168
AkashGoenka merged 1 commit into
mainfrom
claude/coldstartmcp-footer-bug-i89aub

Conversation

@AkashGoenka

@AkashGoenka AkashGoenka commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Moves footer.css imports from being solely in backdrop.css to being imported directly by all three page-shell stylesheets (landing.css, docs.css, and backdrop.css). This ensures every page that renders the <Footer/> component has its styles available without relying on a single indirect import path.

Changes

  • docs.css & landing.css: Added direct @import './footer.css' statements to ensure footer styles are available on all pages using these stylesheets
  • backdrop.css: Updated the comment to reflect the new import strategy and clarify that footer.css is now imported by multiple page-shell stylesheets, not just this one
  • Footer.astro: Updated the component comment to document that footer.css is imported by all three page-shell stylesheets, eliminating the need for a fourth per-page import

Implementation Details

  • Pages that import multiple page-shell stylesheets (demo, live, blog posts) will now parse footer.css twice, but this is harmless since the rules are identical
  • This change makes the footer styling more explicit and less dependent on a single shared import path, reducing the risk of pages silently shipping without footer styles (as mentioned in the original comment)
  • The approach aligns with the principle that every page rendering <Footer/> should have its styles available through the stylesheet it already imports

🤖 Generated with Claude Code

The footer rebuild (94d0940) put all its rules in footer.css and
imported it only from backdrop.css, on the assumption that "every page
that renders <Footer /> already imports backdrop.css." That was never
true: only demo/index.astro, live/index.astro, and BlogPostLayout.astro
import backdrop.css. The home page and everything on docs.css (docs,
blog index, all how-it-works pages, vs/vector-rag) import landing.css
or docs.css directly and never got footer.css at all, so the footer
rendered with zero grid/flex/spacing rules — a single stacked column
of concatenated links.

Import footer.css directly from landing.css and docs.css, the same
way backdrop.css already does, so every page shell carries it without
a fourth per-page import to forget.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@AkashGoenka
AkashGoenka force-pushed the claude/coldstartmcp-footer-bug-i89aub branch from 98455fe to c280a61 Compare September 7, 2026 10:24
@AkashGoenka
AkashGoenka merged commit 30d2b73 into main Sep 7, 2026
8 checks passed
@AkashGoenka
AkashGoenka deleted the claude/coldstartmcp-footer-bug-i89aub branch September 7, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants