Skip to content

Consolidate footer.css imports across page-shell stylesheets #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkashGoenka merged 1 commit into from
Sep 7, 2026
+12 −8
Merged

Consolidate footer.css imports across page-shell stylesheets #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site-astro/src/components/Footer.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
// Styling lives in styles/footer.css, which is pulled in by backdrop.css —
// so a page gets the footer's chrome from the same import that gives it the
// background field. See the comment at the top of footer.css.
// Styling lives in styles/footer.css, imported by all three page-shell
// stylesheets (landing.css, docs.css, backdrop.css) so every page that
// renders this component gets it without a fourth per-page import.
interface Props { variant?: 'home' | 'docs' | 'blog' | 'how' | 'live' }
const { variant = 'docs' } = Astro.props;

Expand Down
12 changes: 7 additions & 5 deletions site-astro/src/styles/backdrop.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
/* The shared footer rides along here on purpose. Every page shell already
imports this file, and a per-page footer import would be a third thing a
new page can silently forget - /live/ shipped without this very file once.
footer.css defines no tokens, so being hoisted above the :root below is
harmless. */
/* footer.css is ALSO imported directly by landing.css and docs.css, the
two page-shell stylesheets that DON'T import this file — this file
alone was not the universal footer carrier the original comment here
claimed: only demo/, live/, and BlogPostLayout import it, while every
page renders <Footer/>. A page that imports both this file and
landing.css/docs.css (demo, live, blog posts) gets footer.css twice;
harmless since the rules are identical, just redundant parsing. */
@import "./footer.css";

/* ============================================================
Expand Down
1 change: 1 addition & 0 deletions site-astro/src/styles/docs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* coldstart docs — dark design system, tokens matched to landing.css
frost = navigation/index, ember = notebook/memory */
@import './tokens.css';
@import './footer.css';

/* ============================================================
THE FIELD — frost bleeding from left, ember from right, over dark ramp.
Expand Down
1 change: 1 addition & 0 deletions site-astro/src/styles/landing.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
temperature = concept: frost = the cold exact index, ember = the warm memory.
============================================================ */
@import './tokens.css';
@import './footer.css';

/* ============================================================
THE FIELD — frost bleeding from left, ember from right, over dark ramp.
Expand Down
Loading