Repository navigation
chore(loop): correct the D33 note (dependabot PRs never reach triage) - #41
Merged
Merged
Conversation
The D33 entry claimed "every owner or dependabot PR gets a task from `pull_request` triage". Dependabot is not one of them: the credential guard (D28) skips the whole job before triage, because a Dependabot-triggered `pull_request` run gets a read-only token and no secrets. So the new `terminal` branch is a no-op for them. The code was always right — `markTaskTerminal` treats a missing task as "no transition needed" — only the reasoning was wrong. Still worth fixing: the note is what the next reader trusts, and a wrong premise there invites a wrong change later. Also fold in what the 2026-09-11 daily sweep established, since it changes how D33 reads: the #39 drift was self-healed by r-20260911-080231-zja0, but only because the #40 triage report had mentioned it in passing. sweep cannot see closures, which is the accidental path D30/D33 exist to remove.
Contributor
Coverage
|
Alex1990
added a commit
that referenced
this pull request
Sep 11, 2026
A clean observation week proves the loop is *safe*, not that it is *complete*. Several capabilities cannot run at the report boundary however long A1 lasts, and the checklist did not distinguish them from items that are merely unsampled. Conflating the two would let a clean week be read as "everything verified". Decision (2026-09-11): accept the metrics write path as unverified and make it the first item after the L2 switchover. A1 produces no loop PR, so `handleMetrics` never fires — all 3 existing acceptance rows are A0-era (`manual-local` x2, `workflow-backfill`). D30/D33 cover the shared machinery (`markTaskTerminal`, the `taskId|event|pr` dedup key) and D33 verified the no-write half live twice; the write half (`planActions`) has never executed in any host. Validating it needs `LOOP_GH_TOKEN` plus `execute_writes=true`, i.e. leaving the report boundary, which is exactly what the observation week is for avoiding. Also corrected while auditing the same list, because a stale checklist is worse than an incomplete one: - `pr-review` is unreachable too — it needs a loop PR, which A1 never produces. #39/#40/#41 were loop-*related* but not loop-*produced* (head `chore/loop-*`), so they routed to `triage`. Recorded run ids for the routes that did run. - Engine stability: 18 runs with no hang, but every one exited 0 — so the failure-classification table has never been exercised by a real failure. - D33's live verification is now recorded as the two independent instances it is (#40, #41), both with no metric row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small correction to my own #40. No behaviour change.
What was wrong
The D33 note claimed:
Dependabot is not one of them. The credential guard (D28) skips the whole job before triage, because a Dependabot-triggered
pull_requestrun gets a read-only token and no secrets at all. So the newterminalbranch is a no-op for dependabot closures.The code was always right —
markTaskTerminaltreats a missing task asno transition needed, which I tested. Only the reasoning was wrong. Worth fixing anyway: the note is what the next reader trusts, and a wrong premise there invites a wrong change later. It still matters if D28 is ever lifted, and it does correctly terminalise the older dependabot task #35 (created before the guard).D33 verified live
34595150462, thepull_request_target.closedrun for #40's merge:Both halves hold, confirmed against R2 (the authority, not the local mirror):
acceptedtasks: 10 (closed=1, accepted=9)acceptance rows: 3Worth noting the run checked out
f9b8278— this PR's own head, via the D24 same-repo-PR rule — so the run that terminalised #40 was already executing the fix.A correction to how D33 reads
The #39 drift did not wait for this fix. The 2026-09-11 daily sweep (
r-20260911-080231-zja0) found and reconciled it:But read the sweep's own §7.1:
That is the whole point. The reconciliation happened because the #40 triage report had mentioned #39 in passing — one run's prose reaching the next day's sweep. If that sentence had not been there, #39 would still be sitting in the inbox.
So sweep's structural blind spot is not fixed; it is now demonstrated by a case where the drift was real, lasted ~13 hours, and was only closed by an accident. The norms-layer fix (sweep should reconcile closure-direction drift, e.g. task
updatedAtvs GitHubmergedAt/closedAt) stays a proposal for after A1's observation week — this PR only makes the defect log say so accurately.