Skip to content

Commit graph: close a commit's panel, and step back with Escape - #252

Open
Amitgb14 wants to merge 1 commit into
masterfrom
conch/graph-back
Open

Amitgb14 wants to merge 1 commit into
masterfrom
conch/graph-back

Conversation

@Amitgb14

Copy link
Copy Markdown
Owner

Clicking a commit in the Commit Graph (#250) opened its panel on the right, and nothing ever closed it: selected was only ever set, so the graph never came back to its whole width. Found by the owner on first use.

  • An × on the commit's panel (also while it loads or failed to), and clicking the picked commit again, close it.
  • Escape steps back one at a time, newest first: the CI panel, the Autopilot panel, a comparison, the commit, a branch's focus. Only while the graph has the keyboard (onExitCommand), so Escape still reaches terminals and agents in other splits.
  • The order and the click rule are in ConchKit (graphBack, pickCloses) with tests.

Tested: swift test, make gate. Not clicked through live.

🤖 Generated with Claude Code

Clicking a commit opened its panel and nothing closed it, so the graph
never came back to its whole width. An × on the panel and a second click
close it; Escape, while the graph has the keyboard, closes the newest
thing opened: CI, Autopilot, a comparison, the commit, a branch's focus.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant