説明用コミット - #44
Open
tachu105 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
チュートリアル用のマスクくり抜き処理(MaskCutout.SetRectangle)に、デバッグ/検証用と思われるコメントおよび GameObject 生成を追加するPRです。
Changes:
SetRectangleに一時的なコメントを追加SetRectangleにnew GameObject("Doodle")の生成処理を追加
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+52
| // これはコミットしたくない | ||
| SetupRectTransform(centerX, centerY, width, height); | ||
| ApplySoftnessRange(paddingRatio, gradientRatio); | ||
|
|
||
| // これはコミットしたい |
There was a problem hiding this comment.
SetRectangle 内に「これはコミットしたくない」という一時的なコメントが残っています。意図が不明でレビュー/保守のノイズになるため、不要なら削除するか、必要な意図なら具体的な TODO/理由に書き換えてください。
Suggested change
| // これはコミットしたくない | |
| SetupRectTransform(centerX, centerY, width, height); | |
| ApplySoftnessRange(paddingRatio, gradientRatio); | |
| // これはコミットしたい | |
| SetupRectTransform(centerX, centerY, width, height); | |
| ApplySoftnessRange(paddingRatio, gradientRatio); |
Comment on lines
+51
to
+53
|
|
||
| // これはコミットしたい | ||
| var doodle = new GameObject("Doodle"); |
There was a problem hiding this comment.
new GameObject("Doodle") が毎回生成されますが、親子付け/破棄/保持がなく、変数も未使用です。このままだと呼び出しのたびにヒエラルキーとメモリが増え続けるため、生成が不要なら削除し、必要なら適切な親へ transform.SetParent(...) し参照管理や破棄方針を明確にしてください。
Suggested change
| // これはコミットしたい | |
| var doodle = new GameObject("Doodle"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
テスト用のPRです。後で消します