Skip to content

説明用コミット #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tachu105 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

説明用コミット #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Assets/Scripts/Mask/MaskCutout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,12 @@ public void SetRectangle(float centerX, float centerY, float width, float height
_subtractImage.sprite = _submaskRectangleSprite;

(width, height) = CalculateCenterSize(_subtractImage, width, height);
// これはコミットしたくない
SetupRectTransform(centerX, centerY, width, height);
ApplySoftnessRange(paddingRatio, gradientRatio);

// これはコミットしたい
Comment on lines +48 to +52

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetRectangle 内に「これはコミットしたくない」という一時的なコメントが残っています。意図が不明でレビュー/保守のノイズになるため、不要なら削除するか、必要な意図なら具体的な TODO/理由に書き換えてください。

Suggested change
// これはコミットしたくない
SetupRectTransform(centerX, centerY, width, height);
ApplySoftnessRange(paddingRatio, gradientRatio);
// これはコミットしたい
SetupRectTransform(centerX, centerY, width, height);
ApplySoftnessRange(paddingRatio, gradientRatio);

Copilot uses AI. Check for mistakes.
var doodle = new GameObject("Doodle");
Comment on lines +51 to +53

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new GameObject("Doodle") が毎回生成されますが、親子付け/破棄/保持がなく、変数も未使用です。このままだと呼び出しのたびにヒエラルキーとメモリが増え続けるため、生成が不要なら削除し、必要なら適切な親へ transform.SetParent(...) し参照管理や破棄方針を明確にしてください。

Suggested change
// これはコミットしたい
var doodle = new GameObject("Doodle");

Copilot uses AI. Check for mistakes.
}

/// <summary>
Expand Down
Loading