Repository navigation
chore: código comentado en inglés - #4
Merged
Merged
Conversation
El proyecto se abre a contribuciones internacionales, así que el código deja de estar comentado en español. - 470 líneas de comentarios traducidas en las cuatro capas, los tests y los scripts, preservando el porqué de cada decisión (los comentarios que documentan lecciones caras se mantienen íntegros) - Mensajes de os.Logger en inglés: los lee quien depura, no el usuario - project.yml, workflows y scripts de build también en inglés - InfoPlist.xcstrings nuevo: el texto del permiso de Recordatorios era español fijo en el Info.plist y un usuario anglófono veía el diálogo del sistema en español; ahora se localiza es/en - Datos de muestra del renderizador en inglés y capturas regeneradas - Verificado: 64/64 claves del catálogo tienen traducción al inglés La UI sigue con claves en español (idioma de desarrollo) traducidas por catálogo, y los docs del proyecto siguen en español, como está decidido.
There was a problem hiding this comment.
Pull request overview
This PR standardizes developer-facing text across the repository by translating comments, logs, and build/script guidance into English, and introduces a localized Reminders permission prompt string via an InfoPlist.xcstrings resource.
Changes:
- Translates inline code comments across Domain/UI/System layers and test suites to English.
- Updates scripts and CI/release workflow comments to English for easier onboarding.
- Adds
Corner/Resources/InfoPlist.xcstringsto localize the Reminders permission usage description (en/es).
Reviewed changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Scripts/render-preview.swift | Translates script header comments and sample seed data text to English. |
| Scripts/render-preview.sh | Translates usage/build notes and error message to English. |
| Scripts/make-demo-gif.sh | Translates usage/help text and parameter error to English. |
| Scripts/generate-icon.swift | Translates documentation comments to English. |
| Scripts/generate-icon.sh | Translates script header comment to English. |
| project.yml | Translates project comments; keeps Reminders usage description key configured. |
| CornerTests/TaskStoreTests.swift | Translates test documentation/comments to English. |
| CornerTests/SyncPlannerTests.swift | Translates test documentation/comments to English. |
| CornerTests/RolloverServiceTests.swift | Translates test comment to English. |
| CornerTests/ReminderScheduleTests.swift | Translates test documentation/comments to English. |
| CornerTests/HotCornerLogicTests.swift | Translates test documentation/comments to English. |
| CornerTests/DayClockTests.swift | Translates test section markers/comments to English. |
| Corner/UI/WeekView.swift | Translates view doc comments to English. |
| Corner/UI/TodayView.swift | Translates view doc comments and inline rationale comment to English. |
| Corner/UI/TaskRow.swift | Translates component docs and inline comments to English. |
| Corner/UI/TaskGroupRows.swift | Translates component docs and section markers to English. |
| Corner/UI/QuickCaptureView.swift | Translates view doc comments to English. |
| Corner/UI/PanelView.swift | Translates view doc comments and inline comments to English. |
| Corner/UI/NewTaskField.swift | Translates view doc comments and inline comments to English. |
| Corner/UI/CategoryColor.swift | Translates palette/docs to English. |
| Corner/UI/CategoryChips.swift | Translates view docs/section markers to English. |
| Corner/System/UpdateChecker.swift | Translates class doc comment to English. |
| Corner/System/ReminderSync.swift | Translates docs and updates log messages to English. |
| Corner/System/QuickCaptureController.swift | Translates controller docs and inline comments to English. |
| Corner/System/PanelController.swift | Translates controller docs and inline comments to English. |
| Corner/System/NotificationScheduler.swift | Translates docs and updates log messages to English. |
| Corner/System/MenuBarController.swift | Translates docs and inline comments to English. |
| Corner/System/HotKeyCenter.swift | Translates docs and inline comments to English. |
| Corner/System/HotCornerMonitor.swift | Translates docs and inline comments to English. |
| Corner/System/FloatingPanel.swift | Translates class doc comment to English. |
| Corner/Resources/InfoPlist.xcstrings | Adds localized (en/es) string for Reminders permission prompt. |
| Corner/Domain/TaskStore.swift | Translates store docs/section markers and log strings to English. |
| Corner/Domain/TaskItem.swift | Translates model docs to English. |
| Corner/Domain/TaskCategory.swift | Translates model docs to English. |
| Corner/Domain/SyncPlanner.swift | Translates domain docs and inline planner rationale to English. |
| Corner/Domain/RolloverService.swift | Translates service docs and log strings to English. |
| Corner/Domain/ReminderSchedule.swift | Translates domain docs/section markers to English. |
| Corner/Domain/HotCornerLogic.swift | Translates domain docs to English. |
| Corner/Domain/DayClock.swift | Translates protocol/docs to English. |
| Corner/App/AppDelegate.swift | Translates composition-root docs and inline comments to English. |
| .github/workflows/release.yml | Translates workflow header comments to English. |
| .github/workflows/ci.yml | Translates workflow matrix rationale comments to English. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+5
| /// A task. Constraints for future CloudKit compatibility (ARCHITECTURE §4): | ||
| /// every attribute has a default, no @Attribute(.unique), no relationships. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
El código pasa a estar comentado en inglés para bajar la barrera a contribuciones internacionales. Incluye los mensajes de log, los scripts de build y —hallazgo del camino— la localización del texto del permiso de Recordatorios, que estaba fijo en español.
Sin cambios de comportamiento: 73 tests en verde.