Skip to content

Harden robustness evidence contracts - #178

Merged
Anionix merged 1 commit into
mainfrom
codex/robustness-contract-fixes
Jul 16, 2026
Merged

Anionix merged 1 commit into
mainfrom
codex/robustness-contract-fixes

Conversation

@Anionix

@Anionix Anionix commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep generated robustness rows consistent with recorded parameters
  • normalize serialized robustness enums and preserve legacy claims reportability
  • reject recursive evidence imports and no-op truncation recipes
  • distinguish read rejection from verification VALUE_MISMATCH
  • resolve relative bounded run directories and restore the full lifecycle contract comment

Addresses the contract/evidence findings tracked in #176 (historical review findings #109-#113 and #126). Native fuzz follow-ups remain separate.

Verification

  • nix develop --command ruff check src tests
  • nix develop --command pyright src/format_bench/model.py src/format_bench/robustness/evidence.py src/format_bench/robustness/mutations.py src/format_bench/robustness/paths.py src/format_bench/robustness/runner.py
  • nix develop --command env PYTHONPATH=src .venv/bin/pytest -q tests/test_model.py tests/test_robustness_cases.py tests/test_robustness_artifacts.py tests/test_robustness_targets.py tests/test_robustness_profile.py tests/test_report.py tests/test_release.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3676d78481

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/format_bench/robustness/worker.py Resolved
Comment thread src/format_bench/robustness/cases.py Resolved
@Anionix
Anionix merged commit 1ffb39b into main Jul 16, 2026
4 checks passed
@Anionix
Anionix deleted the codex/robustness-contract-fixes branch July 16, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant