Skip to content

Accept normalized columns in adapter manifests - #497

Merged
Anionix merged 1 commit into
mainfrom
codex/bug-495-normalized-columns
Jul 24, 2026
Merged

Anionix merged 1 commit into
mainfrom
codex/bug-495-normalized-columns

Conversation

@Anionix

@Anionix Anionix commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Fixes #495

Source review: #488 (comment)

Contract

  • Keep the named AdapterColumn contract for adapter-native manifests.
  • Also accept the repository's existing list[NormalizedColumn] flow without conversion.
  • Preserve runtime behavior; this change is static typing plus contract coverage only.

Verification

  • TDD red: test_adapter_contract_keys_are_explicit rejected the previous list[AdapterColumn]-only annotation.
  • Ruff: PASS.
  • Focused tests: 4 passed.
  • Pyright 1.1.411: 20 files, 0 errors/warnings/information.
  • Targeted specification and scope reviews: PASS.
  • git diff --check: PASS.
  • Lean: NO_LEAN; this is a Python static-type compatibility contract.

Exact SHA: c1081633aa8ac03d05136b931bad3bbdd40bd7f0

Primary sources:

@Anionix
Anionix enabled auto-merge July 24, 2026 06:10
@Anionix
Anionix merged commit c9d37b0 into main Jul 24, 2026
6 checks passed
@Anionix
Anionix deleted the codex/bug-495-normalized-columns branch July 24, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept normalized columns in AdapterManifest

1 participant