Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ include = [
"src/format_bench/adapter_contract.py",
"src/format_bench/artifact_digest.py",
"src/format_bench/registry.py",
"tests/typecheck/adapter_manifest_normalized.py",
"src/format_bench/contracts.py",
"src/format_bench/equivalence.py",
"src/format_bench/json_contract.py",
Expand Down
9 changes: 7 additions & 2 deletions src/format_bench/adapter_contract.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from typing import Literal, NotRequired, TypedDict
from typing import Literal, NotRequired, TypeAlias, TypedDict

from .contracts import NormalizedColumn


class AdapterColumn(TypedDict):
Expand All @@ -7,9 +9,12 @@ class AdapterColumn(TypedDict):
nullable: NotRequired[bool]


AdapterColumns: TypeAlias = list[AdapterColumn] | list[NormalizedColumn]


class AdapterManifest(TypedDict):
rows: int
columns: list[AdapterColumn]
columns: AdapterColumns
canonical_hash: str
expected_counts: dict[str, int]
workloads: NotRequired[dict[str, object]]
Expand Down
2 changes: 2 additions & 0 deletions src/format_bench/formats/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from format_bench.adapter_contract import (
AdapterColumn,
AdapterColumns,
AdapterManifest,
VerificationResult,
)
Expand All @@ -22,6 +23,7 @@
__all__ = [
"Artifact",
"AdapterColumn",
"AdapterColumns",
"AdapterManifest",
"ArrowIpcAdapter",
"AvroAdapter",
Expand Down
7 changes: 6 additions & 1 deletion tests/test_adapter_contract.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from pathlib import Path
from typing import NotRequired, get_args, get_origin, get_type_hints

from format_bench.contracts import NormalizedColumn
from format_bench.formats import (
AdapterColumn,
AdapterManifest,
Expand Down Expand Up @@ -29,7 +30,10 @@ def test_adapter_contract_keys_are_explicit() -> None:
assert get_origin(column_hints["nullable"]) is NotRequired
assert AdapterColumn.__required_keys__ == {"arrow_type", "name"}
assert AdapterColumn.__optional_keys__ == {"nullable"}
assert get_args(manifest_hints["columns"]) == (AdapterColumn,)
assert set(get_args(manifest_hints["columns"])) == {
list[AdapterColumn],
list[NormalizedColumn],
}
assert set(manifest_hints) == {
"canonical_hash",
"columns",
Expand Down Expand Up @@ -71,3 +75,4 @@ def test_adapter_contract_is_in_the_blocking_strict_frontier() -> None:
assert pyright["typeCheckingMode"] == "strict"
assert "src/format_bench/adapter_contract.py" in pyright["include"]
assert "src/format_bench/registry.py" in pyright["include"]
assert "tests/typecheck/adapter_manifest_normalized.py" in pyright["include"]
14 changes: 14 additions & 0 deletions tests/typecheck/adapter_manifest_normalized.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from format_bench.adapter_contract import AdapterManifest
from format_bench.contracts import NormalizedColumn


def manifest_with_normalized_columns(
columns: list[NormalizedColumn],
) -> AdapterManifest:
# LLM contract: RAW_COLUMNS -> NORMALIZED_COLUMNS -> ADAPTER_ACCEPTED.
return {
"rows": 0,
"columns": columns,
"canonical_hash": "",
"expected_counts": {},
}
Loading