uncommon styles by name + docs for the new bank (3/3 for #24) - #49
Open
AnnaWegmann wants to merge 6 commits into
Open
uncommon styles by name + docs for the new bank (3/3 for #24)#49AnnaWegmann wants to merge 6 commits into
AnnaWegmann wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…uncommon-docs # Conflicts: # tests/test_style_bank_loading.py
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last part of #24, stacked on #48 (the diff shown is relative to it).
The two styles outside the default bank (
old_english,middle_english) can now be selected by name, e.g.styles=["old_english"]. They still have no index and are never picked byn. Each method can say which of these extra styles it accepts, via a newuncommon_style_bankclass attribute;zero_shotsets it to{}because its styles are instructions, not example texts. The error for an unknown style name now also lists these name-only styles.Also updates the README and docs: all code examples now use style names that exist in the new bank, the name-only styles are explained, and the paragraph about where the old bank's texts came from is replaced with a short description of the new bank. Not updated: the example outputs in
docs/longer_texts.rstand the README quickstart — those were generated with the old styles, and new ones need a real model run.Written by Claude and Anna