test: improve coverage on portfolio header components#1864
Merged
Conversation
goga-m
requested review from
ItsANameToo,
alexbarnsley,
boldninja and
samharperpittam
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
goga-m
commented
May 28, 2026
Comment on lines
-65
to
+71
| const handleSendRegistration = (registrationType?: "validatorRegistration" | "usernameRegistration") => { | ||
| if (registrationType === "validatorRegistration") { | ||
| openPanel(Panel.SendValidatorRegistration); | ||
| } else { | ||
| openPanel(Panel.SendUsernameRegistration); | ||
| } | ||
| }; | ||
|
|
||
| const handleSendContractDeployment = () => { | ||
| openPanel(Panel.SendContractDeployment); | ||
| }; | ||
|
|
||
| const handleSendUsernameResignation = () => { | ||
| openPanel(Panel.SendUsernameResignation); | ||
| }; | ||
|
|
||
| const handleSendValidatorResignation = () => { | ||
| openPanel(Panel.SendValidatorResignation); | ||
| }; | ||
| const { | ||
| handleSendRegistration, | ||
| handleSendContractDeployment, | ||
| handleSendUsernameResignation, | ||
| handleSendValidatorResignation, | ||
| } = usePortfolioHeaderActions(); |
Contributor
Author
There was a problem hiding this comment.
@ItsANameToo @shahin-hq this is the only code change, the test in UI can be simply to see if the sidepanels open for the above flows.
ItsANameToo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://app.clickup.com/t/86e0bj61v
Extracted from #1811
Checklist