test: increase coverage thresholds on portfolio domain#1811
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
goga-m
commented
May 27, 2026
Comment on lines
-492
to
+495
| COVERAGE_THRESHOLD_LINES: 77.55 | ||
| COVERAGE_THRESHOLD_FUNCTIONS: 73.98 | ||
| COVERAGE_THRESHOLD_STATEMENTS: 77.69 | ||
| COVERAGE_THRESHOLD_BRANCHES: 69.85 | ||
| COVERAGE_THRESHOLD_LINES: 97.57 | ||
| COVERAGE_THRESHOLD_FUNCTIONS: 94.9 | ||
| COVERAGE_THRESHOLD_STATEMENTS: 97.46 | ||
| COVERAGE_THRESHOLD_BRANCHES: 94.31 |
Contributor
Author
There was a problem hiding this comment.
There are new lines left uncovered after the recent dep updates on coverage libraries, but can cover them on a second batch as this PR got already big
goga-m
requested review from
ItsANameToo,
alexbarnsley,
boldninja and
samharperpittam
as code owners
7 tasks
This was referenced May 28, 2026
goga-m
changed the title
ItsANameToo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86e0bj61v
Coverage threshold increase after merging the subsequent PRs
#1862
#1867
#1866
#1865
#1864
#1863
Checklist