Skip to content

test: improve coverage on wallet import flow#1867

Merged
ItsANameToo merged 4 commits into
feat/mainsailfrom
test/import-wallet-wallet-tests
May 29, 2026
Merged

test: improve coverage on wallet import flow#1867
ItsANameToo merged 4 commits into
feat/mainsailfrom
test/import-wallet-wallet-tests

Conversation

@goga-m
Copy link
Copy Markdown
Contributor

@goga-m goga-m commented May 28, 2026

Summary

Part of https://app.clickup.com/t/86e0bj61v
Extracted from #1811

  • No code changes, only test coverage.

QA - Flows to test that are affected

  1. Import Wallet — mnemonic/secret/public key
  • Import a duplicate public key that already exists in the profile → verify the validation error banner appears with "public key already exists"
  • Paste an invalid mnemonic or secret → verify the address resolution fails and shows the mnemonic validation error
  • Exit the side panel while on the "Encrypt Password" step → verify the temporary imported wallet is forgotten and not
    saved
  1. Ledger Import
  • Connect a Ledger device → verify it detects the device, transitions to the scan step, finds addresses, lets you select them, and imports them successfully
  1. Wallet Name Update
  • Edit a wallet name → save → verify the alias persists; cancel → verify it closes without saving

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
arkvault Ready Ready Preview May 29, 2026 8:51am

Request Review

@ItsANameToo ItsANameToo merged commit 7001aa3 into feat/mainsail May 29, 2026
23 checks passed
@ItsANameToo ItsANameToo deleted the test/import-wallet-wallet-tests branch May 29, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants