feat(two-thumb): remove the re-recognize-taps (live-converge) feature#47
Merged
Conversation
Removes PREF_MULTIPART_RERECOGNIZE_TAPS and its machinery. On-device dogfooding showed the behavior was disliked: re-recognizing a tap after a swipe is destructive (you stop seeing the letter you tapped), it blocks typing words the recognizer doesn't know, and it isn't unified with starting a word by typing. The only case it improved -- swiping a partial word and then finishing it with taps -- is rare and not worth those costs. With it gone, a tap after a swipe appends literally (you see exactly what you typed). The multi-part composition users rely on (swipe+swipe, tap+swipe, swipe+tap -> one word, via the seed/concat and setExtendBatchInputBase merged-trail path) is unchanged -- it never depended on this flag. Removed: - the pref across the 5-file pattern (Settings / Defaults / SettingsValues / strings.xml / TwoThumbTypingScreen) - InputLogic: tryLiveConvergeTap, mLiveStroke + all its resets, the per-commit snapshot, and the now-orphaned getBatchSuggestionsSync - the obsolete liveConvergeOnDegradesGracefully unit test - updated docs/TWO_THUMB_TYPING_INTERNALS.md section 4.12 (marked REMOVED) A non-destructive "offer, don't replace" successor is tracked in #27 (B2). Verified (JDK 21): full offline unit suite = 217 tests, 11 failed -- all 11 are the documented pre-existing failures (parser / xlink / emoji / 3 known InputLogic); 0 new. Only InputLogicTest was touched (one obsolete test removed); SettingsContainerTest passes. Part of #27.
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27.
Removes
PREF_MULTIPART_RERECOGNIZE_TAPSand its machinery. On-device dogfooding showed the behavior was disliked:The only case it improved — swiping a partial word then finishing it with taps — is rare and not worth those costs. With it gone, a tap after a swipe just appends literally (you see exactly what you typed).
Multi-part composition is unchanged. The swipe+swipe / tap+swipe / swipe+tap → one-word behavior (seed/concat +
setExtendBatchInputBasemerged-trail) never depended on this flag and is untouched.Removed
InputLogic:tryLiveConvergeTap,mLiveStroke+ all resets, the per-commit snapshot, and the now-orphanedgetBatchSuggestionsSyncliveConvergeOnDegradesGracefullyunit testdocs/TWO_THUMB_TYPING_INTERNALS.md§4.12 marked REMOVEDVerification (JDK 21)
Full offline unit suite = 217 tests, 11 failed — all 11 are the documented pre-existing failures (parser/xlink/emoji + 3 known InputLogic), 0 new. Only
InputLogicTestwas touched (one obsolete test removed);SettingsContainerTestpasses.A non-destructive "offer, don't replace" successor is tracked in #27 (B2).