Skip to content

Newsletter: Add Send newsletter by default toggle to settings#47565

Merged
arcangelini merged 7 commits intotrunkfrom
add/newsletter-send-default-setting
Mar 18, 2026
Merged

Newsletter: Add Send newsletter by default toggle to settings#47565
arcangelini merged 7 commits intotrunkfrom
add/newsletter-send-default-setting

Conversation

@arcangelini
Copy link
Copy Markdown
Member

@arcangelini arcangelini commented Mar 12, 2026

Fixes https://linear.app/a8c/issue/NL-486/allow-site-owners-to-set-default-newsletter-send-behavior-post-only-vs

Proposed changes

Jetpack Simple
Screen Shot 2026-03-18 at 00 43 39 Cell
Screen Shot 2026-03-18 at 00 44 05 Cell
  • Adds a "Send newsletter by default" toggle to the Newsletter settings card in both the new newsletter settings page and the old Jetpack dashboard
  • The toggle controls the wpcom_newsletter_send_default option introduced in Newsletter: Add wpcom_newsletter_send_default option #47564
  • When subscriptions are disabled, the toggle shows as off and disabled
  • Uses ToggleControl (matching the existing subscriptions toggle pattern) with an info popover for the description
  • Removes all references to the old wpcom_newsletter_default_publish_behavior radio control

Other information

Does this pull request change what data or activity we track or use?

Adds a new Tracks event jetpack_newsletter_set_send_default when the toggle is changed.

Testing instructions

  • Merge or check out Newsletter: Add wpcom_newsletter_send_default option #47564 first (this PR is based on it)
  • Go to Jetpack > Settings > Newsletter
  • Verify the "Send newsletter by default" toggle appears below the subscriptions toggle
  • Toggle it off - verify the setting saves and the editor now defaults to "Post only"
  • Toggle it on - verify the editor defaults to "Post & email"
  • Disable the subscriptions module - verify the send default toggle becomes disabled and unchecked
  • Click the info popover icon - verify it shows the description text and Learn more link
  • For the new newsletter settings page (wp-admin/admin.php?page=jetpack-newsletter), verify the same toggle appears and functions correctly

@github-actions github-actions bot added [Package] Newsletter [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: March 31, 2026
    • Code freeze: March 31, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/newsletter-send-default-setting branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/newsletter-send-default-setting
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/newsletter-send-default-setting

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 12, 2026
@arcangelini arcangelini self-assigned this Mar 12, 2026
@arcangelini arcangelini requested a review from a team March 12, 2026 16:42
@arcangelini arcangelini added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 12, 2026
@github-actions github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Mar 12, 2026
@arcangelini arcangelini force-pushed the add/newsletter-send-default-setting branch from 043ee49 to 55a9e9b Compare March 12, 2026 16:51
@arcangelini arcangelini removed the request for review from a team March 12, 2026 16:55
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Mar 12, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/_inc/client/newsletter/newsletter.jsx 11/20 (55.00%) 1.67% 2 ❤️‍🩹

Full summary · PHP report · JS report

@arcangelini arcangelini force-pushed the add/newsletter-send-default-setting branch from 55a9e9b to 7ec7780 Compare March 12, 2026 17:30
@arcangelini arcangelini force-pushed the add/newsletter-send-default-option branch from 31e0dfb to 34b8d49 Compare March 13, 2026 15:52
@arcangelini arcangelini requested a review from a team as a code owner March 13, 2026 15:52
@arcangelini arcangelini force-pushed the add/newsletter-send-default-setting branch from 0641516 to 5a0b86c Compare March 13, 2026 15:52
@arcangelini arcangelini force-pushed the add/newsletter-send-default-option branch from f49b49f to 48bf829 Compare March 15, 2026 16:30
Base automatically changed from add/newsletter-send-default-option to trunk March 16, 2026 09:34
@arcangelini arcangelini force-pushed the add/newsletter-send-default-setting branch from 5a0b86c to 34ce296 Compare March 16, 2026 10:30
type: 'boolean' as const,
Edit: 'toggle' as const,
},
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section isn't available to simple sites - they can't toggle Jetpack modules on and off. This is implemented in

{ ! isSimpleSite() && <NewsletterSection data={ data } onChange={ handleAutoSave } /> }
Maybe we need to move that logic inside this section so it displays everything except the module toggle.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point! Let me tweak this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up tweaking this. I left the setting in this section and instead made the section visible in Simple sites minus the module toggle. I think this brings closer parity and offers a point to the subscribers.

I am not sure how to test this though, do you have any insight on this @dsas

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Get the files in your sandbox using jetpack rsync or the commands suggested in the PR comment.
  2. Use the BRC to toggle newsletter-package-202603 on
  3. Sandbox the site, public-api, etc

dsas
dsas previously approved these changes Mar 16, 2026
Copy link
Copy Markdown
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, thank you.

</ModuleToggle>
</SettingsGroup>

<SettingsGroup
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a big deal but this SettingsGroup repeats the Privacy information link

Image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsas I think that is the same across all the support help popovers. I noticed the same but it was consistent across all of them and assumed it was by design.

@arcangelini arcangelini merged commit a234787 into trunk Mar 18, 2026
73 checks passed
@arcangelini arcangelini deleted the add/newsletter-send-default-setting branch March 18, 2026 08:22
@github-actions github-actions bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels Mar 18, 2026
@alexapeduzzi
Copy link
Copy Markdown

CleanShot 2026-03-27 at 12 08 51@2x

Hey team! I'm working on the WordPress.com changelog for today, and I noticed the styling related to this PR is a bit clunky. cc @arcangelini

@arcangelini
Copy link
Copy Markdown
Member Author

@alexapeduzzi thanks for the feedback. This link was there before in the same place so it wasn't necessarily introduced in this PR. However I do agree that it didn't look great so I moved it to the footer in this PR #47830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Block] Subscriptions [Feature] WPCOM API [Package] Newsletter [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants