Newsletter: Add Send newsletter by default toggle to settings#47565
Newsletter: Add Send newsletter by default toggle to settings#47565arcangelini merged 7 commits intotrunkfrom
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
043ee49 to
55a9e9b
Compare
Code Coverage SummaryCoverage changed in 1 file.
|
55a9e9b to
7ec7780
Compare
31e0dfb to
34b8d49
Compare
0641516 to
5a0b86c
Compare
f49b49f to
48bf829
Compare
5a0b86c to
34ce296
Compare
| type: 'boolean' as const, | ||
| Edit: 'toggle' as const, | ||
| }, | ||
| { |
There was a problem hiding this comment.
This section isn't available to simple sites - they can't toggle Jetpack modules on and off. This is implemented in
Maybe we need to move that logic inside this section so it displays everything except the module toggle.There was a problem hiding this comment.
Oh good point! Let me tweak this.
There was a problem hiding this comment.
I ended up tweaking this. I left the setting in this section and instead made the section visible in Simple sites minus the module toggle. I think this brings closer parity and offers a point to the subscribers.
I am not sure how to test this though, do you have any insight on this @dsas
There was a problem hiding this comment.
- Get the files in your sandbox using jetpack rsync or the commands suggested in the PR comment.
- Use the BRC to toggle
newsletter-package-202603on - Sandbox the site, public-api, etc
| </ModuleToggle> | ||
| </SettingsGroup> | ||
|
|
||
| <SettingsGroup |
There was a problem hiding this comment.
Thanks @dsas I think that is the same across all the support help popovers. I noticed the same but it was consistent across all of them and assumed it was by design.
Hey team! I'm working on the WordPress.com changelog for today, and I noticed the styling related to this PR is a bit clunky. cc @arcangelini |
|
@alexapeduzzi thanks for the feedback. This link was there before in the same place so it wasn't necessarily introduced in this PR. However I do agree that it didn't look great so I moved it to the footer in this PR #47830 |


Fixes https://linear.app/a8c/issue/NL-486/allow-site-owners-to-set-default-newsletter-send-behavior-post-only-vs
Proposed changes
wpcom_newsletter_send_defaultoption introduced in Newsletter: Add wpcom_newsletter_send_default option #47564ToggleControl(matching the existing subscriptions toggle pattern) with an info popover for the descriptionwpcom_newsletter_default_publish_behaviorradio controlOther information
Does this pull request change what data or activity we track or use?
Adds a new Tracks event
jetpack_newsletter_set_send_defaultwhen the toggle is changed.Testing instructions