Newsletter: Fix spacing for manage subscribers link#47830
Newsletter: Fix spacing for manage subscribers link#47830arcangelini wants to merge 4 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
9107525 to
a4cf0ce
Compare
Summary
The link for "Manage all subscribers" was not looking great at the bottom of the options. It was a little too close to the text above and generally looked awkward between the option and link in the CardFooter. I tested a few options like extra margin or a divider to match the link below. In the end the best fix was to move this to the footer alongside the "Privacy information" link.
Follows up on #47565.
Testing instructions
Does this pull request change what data or activity we track or use?
No