Skip to content

Newsletter: Fix spacing for manage subscribers link#47830

Open
arcangelini wants to merge 4 commits intotrunkfrom
fix/subscriber-toggle-spacing
Open

Newsletter: Fix spacing for manage subscribers link#47830
arcangelini wants to merge 4 commits intotrunkfrom
fix/subscriber-toggle-spacing

Conversation

@arcangelini
Copy link
Copy Markdown
Member

@arcangelini arcangelini commented Mar 29, 2026

Summary

The link for "Manage all subscribers" was not looking great at the bottom of the options. It was a little too close to the text above and generally looked awkward between the option and link in the CardFooter. I tested a few options like extra margin or a divider to match the link below. In the end the best fix was to move this to the footer alongside the "Privacy information" link.

Simple Jetpack
Before Screen Shot 2026-03-29 at 17 49 03 Screen Shot 2026-03-29 at 17 48 38
After Screen Shot 2026-03-29 at 17 38 37 Screen Shot 2026-03-29 at 17 47 34

Follows up on #47565.

Testing instructions

  • Go to wp-admin/admin.php?page=jetpack-newsletter
  • Enable the subscriptions toggle
  • Verify the "Manage all subscribers" looks good
  • Toggle subscriptions off — verify the link disappears cleanly with no layout shift

Does this pull request change what data or activity we track or use?

No

@arcangelini arcangelini self-assigned this Mar 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/subscriber-toggle-spacing branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/subscriber-toggle-spacing
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/subscriber-toggle-spacing

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 29, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Mar 29, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@arcangelini arcangelini force-pushed the fix/subscriber-toggle-spacing branch from 9107525 to a4cf0ce Compare March 29, 2026 12:55
@arcangelini arcangelini requested a review from a team March 29, 2026 15:43
@arcangelini arcangelini marked this pull request as ready for review March 29, 2026 15:53
@arcangelini arcangelini added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant