Skip to content

Newsletter: Fix spacing for manage subscribers link #47830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcangelini merged 4 commits into from
Mar 30, 2026
+20 −11
Merged

Newsletter: Fix spacing for manage subscribers link #47830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
412332d
Fix spacing for subscriber toggle manage link
arcangelini Mar 29, 2026
71d2fbc
Use CSS logical property for RTL support
arcangelini Mar 29, 2026
a4cf0ce
Move Manage subscribers link to footer row
arcangelini Mar 29, 2026
fafdda4
Move to the right
arcangelini Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/newsletter/changelog/fix-subscriber-toggle-spacing
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix spacing between the send-default toggle description and the Manage all subscribers link in the Newsletter settings card.
20 changes: 9 additions & 11 deletions projects/packages/newsletter/src/settings/sections/newsletter-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,23 +130,21 @@ export function NewsletterSection( { data, onChange }: NewsletterSectionProps ):
} }
onChange={ handleChange }
/>
{ data.subscriptions && newsletterScriptData && (
<div>
<ExternalLink
href={ newsletterScriptData.subscriberManagementUrl }
onClick={ handleManageSubscribersClick }
>
{ __( 'Manage all subscribers', 'jetpack-newsletter' ) }
</ExternalLink>
</div>
) }
</CardBody>
<CardFooter>
<CardFooter className="newsletter-card-footer">
Copy link
Copy Markdown
Member

@simison simison Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please use the component system for this instead of adding more CSS.

Couple options

<ExternalLink
href={ getRedirectUrl( 'jetpack-support-subscriptions', { anchor: 'privacy' } ) }
>
{ __( 'Privacy information', 'jetpack-newsletter' ) }
</ExternalLink>
{ data.subscriptions && newsletterScriptData && (
<ExternalLink
href={ newsletterScriptData.subscriberManagementUrl }
onClick={ handleManageSubscribersClick }
>
{ __( 'Manage all subscribers', 'jetpack-newsletter' ) }
</ExternalLink>
) }
</CardFooter>
</Card>
);
Expand Down
7 changes: 7 additions & 0 deletions projects/packages/newsletter/src/settings/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,11 @@
.components-card__body > p:first-child {
margin-top: 0;
}

.newsletter-card-footer {
display: flex;
flex-wrap: wrap;
justify-content: space-between;
gap: 8px;
}
}
Loading