Test/e2e coverage expansion - #396
Merged
Merged
Conversation
mock-llm gains one-shot failNextNarrative (500) and holdNextNarrative/releaseNarrative (held stream) for the failure and cancel specs; the duplicated window.aventurasDb bridge read is lifted into harness/db.ts as queryApp and adopted by the turn/classifier/wizard specs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
reader.ts centralizes composer/mode/entry-row/menu/rollback locators (EntryCard's hardcoded-English action labels live here, per triage); wizard.ts adds the embed-gate title and save-draft; create-story.ts adds createCreativeStory. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds nine packaged specs — creative create, resume-draft promotion, embedder-gate block, undo/redo, edit, rollback, failure-then-retry, cancel mid-turn, composer modes — each driving through the UI and asserting via the DB bridge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
testing.md notes failNextNarrative/holdNextNarrative in the Mock LLM section; triage narrows the backfill item to what remains (opening-only turn, config surfaces, regenerate, blocked hydration-failure) and logs the EntryCard i18n debt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThe PR expands E2E infrastructure with app-database queries and controllable mock narrative streams, adds centralized reader and wizard locators, and introduces coverage for reader interactions and story wizard creation, gating, and draft resumption. ChangesE2E harness and assertion infrastructure
Reader interaction coverage
Story wizard coverage
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes