Repository navigation
Switch rules_node_addon to BCR 1.0.2 - #1364
Merged
Merged
Conversation
rules_node_addon 1.0.2 is now published in the Bazel Central Registry, so the GitHub tarball archive_override is no longer needed. Bump the bazel_dep to 1.0.2 and resolve it from BCR.
node-addon-api 8.9.0 is now available in the Bazel Central Registry; upgrade from 8.8.0.bcr.1 to the upstream 8.9.0 release.
Collaborator
|
Maybe we should consider implementing a Dependabot for BCR rules? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rules_node_addonfrom1.0.1to1.0.2inMODULE.bazel.archive_overridethat fetched therules_node_addonrelease tarball from GitHub, along with its accompanying comment.MODULE.bazel.lockso the module now resolves from the Bazel Central Registry (bcr.bazel.build/modules/rules_node_addon/1.0.2/).Why
rules_node_addon1.0.2 is now published in the Bazel Central Registry, so the manual GitHub tarball override is no longer necessary. Resolving from BCR simplifies the dependency setup and removes a hand-maintained integrity hash / URL.Notes for reviewers
bazel mod deps --lockfile_mode=update) and now points at the BCR source.bazel build //node:opencccompletes successfully and producesopencc.node.