Skip to content

Switch rules_node_addon to BCR 1.0.2 #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankslin merged 2 commits into from
Jun 29, 2026
Merged

Switch rules_node_addon to BCR 1.0.2 #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910222
Switch rules_node_addon to BCR 1.0.2
BYVoid Jun 29, 2026
232a5e1
Bump node_addon_api to BCR 8.9.0
BYVoid Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ bazel_dep(name = "aspect_rules_js", version = "3.2.2")
bazel_dep(name = "darts-clone", version = "0.32")
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True)
bazel_dep(name = "marisa-trie", version = "0.3.1.bcr.2")
bazel_dep(name = "node_addon_api", version = "8.8.0.bcr.1")
bazel_dep(name = "node_addon_api", version = "8.9.0")
bazel_dep(name = "platforms", version = "1.1.0")
bazel_dep(name = "pybind11_bazel", version = "3.0.1")
bazel_dep(name = "rapidjson", version = "1.1.0.bcr.20250205")
bazel_dep(name = "rules_cc", version = "0.2.20")
bazel_dep(name = "rules_node_addon", version = "1.0.1")
bazel_dep(name = "rules_node_addon", version = "1.0.2")
bazel_dep(name = "rules_nodejs", version = "6.7.4")
bazel_dep(name = "rules_python", version = "2.0.3")
bazel_dep(name = "rules_zig", version = "0.14.0")
Expand All @@ -30,14 +30,6 @@ single_version_override(
version = "2.0.3",
)

# rules_node_addon is not in the Bazel Central Registry; fetch the release tarball.
archive_override(
module_name = "rules_node_addon",
integrity = "sha256-l7HlY7g3HFRGtgLfey08jNsCkHHK0K+5M1YYr3AVyhY=",
strip_prefix = "rules_node_addon-1.0.1",
urls = ["https://github.com/BYVoid/rules_node_addon/archive/refs/tags/v1.0.1.tar.gz"],
)

# Windows x64 node.lib import library for Zig/MinGW addon linking. node-addon-api
# comes from BCR (above) and the Node C headers come from the rules_nodejs Node
# toolchain (below); this import library is available from neither.
Expand Down
9 changes: 6 additions & 3 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading