Repository navigation
s2t: fix 托/託 candidate priority so 托 stays unconverted by default - #1405
Merged
Merged
Conversation
托 was defaulting to 託 for every unmatched occurrence, which is wrong for its "support/hold" and name-transliteration senses; swap the candidate order and backfill the phrase entries that keep the "entrust" sense of 託 working correctly. Detailed Changes: - **STCharacters.txt**: Swap the s2t candidate order for 托 from `託 托` to `托 託` so the character defaults to 托 (e.g. 托着, 茶托, 酒托, 狄托, 托津) instead of 託. - **STPhrases.txt**: Expand 托儿所 to `托兒所 託兒所`, and add the missing entrust-sense entries 托之空言 -> 託之空言 and 托物寓兴 -> 託物寓興 so they still convert to 託 despite the character-level default change. - **testcases.json**: Add BYVoid_OpenCC_Issue_1397 covering mixed 托/託 usages (names, 茶托, 托着) across s2t/s2tw/s2twp/s2hk, and BYVoid_OpenCC_Issue_1397_tuo_entrust_words covering 23 common entrust-sense 託 compounds.
frankslin
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
托 was defaulting to 託 for every unmatched occurrence, which is wrong for its "support/hold" and name-transliteration senses; swap the candidate order and backfill the phrase entries that keep the "entrust" sense of 託 working correctly.
Detailed Changes:
託 托to托 託so the character defaults to 托 (e.g. 托着, 茶托, 酒托, 狄托, 托津) instead of 託.托兒所 託兒所, and add the missing entrust-sense entries 托之空言 -> 託之空言 and 托物寓兴 -> 託物寓興 so they still convert to 託 despite the character-level default change.Fixes #541, #1397