Repository navigation
Sync TWVariantsRevPhrases with STPhrases to disambiguate 梁/樑 in tw2t - #1424
Merged
Merged
Conversation
Cover the 41 TWVariantsRevPhrases entries added in this PR with a tw2t case so the Taiwan-form 梁 phrases convert to the OpenCC-standard 樑 form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Taiwan standard the beam sense of 樑 is written as 梁, so it collapses
with the surname/place-name 梁. Character-level TWVariantsRev cannot tell
the two apart on the way back, which left tw2t (and the tw2* segmentation
chain) unable to restore 樑 for beam phrases — 橋梁 round-tripped to 橋樑
via s2t but stayed 橋梁 via tw2t, an inconsistency with STPhrases.
This adds the missing phrase-level reverse mappings so that whole beam
phrases are recovered from context, while genuine 梁 words (surnames,
place names) are preserved.
Detailed Changes:
(e.g. 上梁文 -> 上樑文, 國家棟梁 -> 國家棟樑, 橫打鼻梁兒 -> 橫打鼻樑兒),
so tw2t converts the Taiwan 梁 form back to the OpenCC-standard 樑.
梁龍, ...) so proper nouns are not over-converted.
distinction against regressions.