Repository navigation
t2s: 乾斷食 → 干断食, 乾紅 → 干红 - #1429
Merged
Merged
Conversation
Closed
Add TSPhrases entry for 乾斷食 → 干断食 so the dry-fasting term takes priority over the shorter 乾斷 → 乾断 match. Update 乾紅 to carry 干红 as the primary candidate (dry red wine) alongside 乾红 as an alternative. Add corresponding test cases for t2s, tw2s, hk2s, tw2sp, and hk2sp.
Copilot
AI
changed the title
[WIP] Add t2s mode conversion rules for 乾斷 and 乾紅
Fix t2s over-conversion: 乾斷食 → 干断食, 乾紅 → 干红
Jul 15, 2026
frankslin
marked this pull request as ready for review
July 15, 2026 00:50
frankslin
changed the title
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
t2sand related configs,乾斷食(dry fasting) was incorrectly converted to乾断食instead of干断食, and乾紅(dry red wine) only produced乾红while missing the more common干红form.Changes
data/dictionary/TSPhrases.txt乾斷食 → 干断食: the longer phrase takes longest-prefix-match priority over the existing乾斷 → 乾断entry, producing the correct simplified form for the dry-fasting context乾紅 → 乾红to乾紅 → 干红 乾红: promotes干红as the default candidate (dry red wine usage) while keeping乾红(deep red color, read qián hóng) as an alternativetest/testcases/testcases.jsonBYVoid_OpenCC_Issue_621_qian_duan_shi: asserts乾斷食 → 干断食acrosst2s,tw2s,hk2s,tw2sp,hk2spBYVoid_OpenCC_Issue_621_qian_hong: asserts乾紅 → 干红across the same five configs