Repository navigation
fix(dictionary): update TSPhrases for 乾紅/谿/列印度/喬治亞 (#901) - #1447
Closed
stantheman0128 wants to merge 1 commit into
Closed
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
…列印 substrings (BYVoid#901) Co-authored-by: Cursor <cursoragent@cursor.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #901.
Problem
TSPhrases.txtwas missing several phrase-level overrides requested in #901:乾紅*forms for dry-red wine / dried safflower / dried jujube (干红*), beyond the short乾紅 -> 干红 乾红entry from t2s: 乾斷食 → 干断食, 乾紅 → 干红 #1429 / TS 可能的过度转换:乾斷,乾紅 #621.谿compounds (豁谿/谿刻/谿卡/谿壑) were simplified to溪viaTSCharacters, even though these should keep谿(related: update TSCharacters.txt #905).tw2sp,列印 -> 打印is applied by longest prefix match inside longer strings, so:喬治亞should stay乔治亚·...in mainland mode (related: 納米比亞,喬治亞州,喬治亞共和國 轉換問題 #902).Change
data/dictionary/TSPhrases.txt:TWPhrasesRev.txt/TWPhrases.txt(needed fortw2sp/ reverse-mapping closure; same MaxMatch pattern as #907):Ordinary
列印 -> 打印is unchanged. Dictionaries sorted withdata/scripts/sort.py.Test plan
BYVoid_OpenCC_Issue_901_*intest/testcases/testcases.json列印 -> 打印undertw2spEvidence
Repro before (packaged wheel dictionaries, or master text dicts for the
tw2sp列印 case):After this branch (config JSONs with
ocd2refs switched to text, drivingdata/dictionary/*.txton the branch):Harness summary (OpenCC 1.4.1 wheel, config
ocd2references rewritten to text):Please treat CI Bazel dictionary tests as authoritative.
AI assistance
This fix was developed with AI assistance (Cursor / Grok) and verified locally as shown above.