Repository navigation
t2s: keep cover-sense 覆 and mat-sense 藉 in TSPhrases (#536) - #1455
Closed
stantheman0128 wants to merge 1 commit into
Closed
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
Per the simplified Chinese standard (same basis as BYVoid#1071), 覆 meaning cover/overturn stays 覆, and 藉 meaning mat/disorder stays 藉. Reply-sense 覆->复 and borrow-sense 藉->借 are unchanged. Fixes BYVoid#536 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #536.
Summary
TSPhrases.txtstill forced a few cover-sense覆and mat/disorder-sense藉phrases to复/借. That disagrees with the simplified Chinese standard (same basis as #1071 for射覆):覆meaning cover / overturn stays覆藉meaning mat / disorder / classical non-borrow senses stays藉覆(答覆/反覆/回覆/批覆) still goes to复藉(藉口/憑藉/藉端生事/狐藉虎威) still goes to借Change
data/dictionary/TSPhrases.txt(identity keep):data/dictionary/STPhrases.txt: remove the matching reverse entries that taught the incorrect simplified forms (same pattern as #1071).Left alone on purpose (policy / out of consensus scope): reply-sense
覆phrases, borrow-sense藉phrases, and ambiguous items such as顧藉/覆按.AI assistance
This PR was prepared with AI assistance (Cursor / Grok). Stan Shih (stantheman0128) reviewed the dictionary choices against the simplified-character rules and the harness output before opening the PR.
Test plan
BYVoid_OpenCC_Issue_536_*intest/testcases/testcases.json覆and borrow-sense藉still convertEvidence
Before (packaged wheel dictionaries):
After this branch (config JSON
ocd2refs rewritten to text, drivingdata/dictionary/*.txt):Harness summary (OpenCC 1.4.1 wheel, text-dict harness):