Add parametrization for default deep, and limit for max depth#18
Open
jacopobonomi wants to merge 2 commits into
Open
Add parametrization for default deep, and limit for max depth#18jacopobonomi wants to merge 2 commits into
jacopobonomi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Christofer,
However, I encountered a security problem related to a possible DOS attack if the API is called with the deep parameter, . This causes the application to go out of memory and if it is managed through a process manager it is restarted, otherwise it crashes. I added in this fork a control with variables inserted directly into the .env file to allow users to customize the maximum and default depth.