Skip to content

Add parametrization for default deep, and limit for max depth #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacopobonomi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add parametrization for default deep, and limit for max depth #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8335560
feat: add params to manage default and max populate depth
Oct 6, 2022
6159846
fix: add condition to limit number of deep
Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "strapi-plugin-populate-deep",
"version": "0.1.2",
"name": "strapi-plugin-populate-deep-with-params",
"version": "0.1.4",
"description": "This is the description of the plugin.",
"strapi": {
"name": "strapi-plugin-populate-deep",
Expand All @@ -18,7 +18,7 @@
],
"repository": {
"type": "git",
"url": "https://github.com/Barelydead/strapi-plugin-deep-populate"
"url": "https://github.com/jacopobonomi/strapi-plugin-deep-populate"
},
"engines": {
"node": ">=12.x. <=16.x.x",
Expand Down
2 changes: 1 addition & 1 deletion server/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = ({ strapi }) => {
const populate = event.params?.populate;

if (populate && populate[0] === 'deep') {
const depth = populate[1] ?? 5
const depth = populate[1] ?? process.env.DEFAULT_POPULATE_DEPTH ?? 5;
const modelObject = getFullPopulateObject(event.model.uid, depth);
event.params.populate = modelObject.populate
}
Expand Down
14 changes: 11 additions & 3 deletions server/helpers/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@ const getModelPopulationAttributes = (model) => {
return model.attributes;
};

const getFullPopulateObject = (modelUid, maxDepth = 20) => {
const getFullPopulateObject = (
modelUid,
maxDepth = process.env.MAX_POPULATE_DEPTH ?? 20
) => {

if (maxDepth > process.env.MAX_POPULATE_DEPTH) {
maxDepth = process.env.MAX_POPULATE_DEPTH;
}

if (maxDepth <= 1) {
return true;
}
Expand Down Expand Up @@ -48,5 +56,5 @@ const getFullPopulateObject = (modelUid, maxDepth = 20) => {
};

module.exports = {
getFullPopulateObject
}
getFullPopulateObject,
};