[family] duct_takeoff_starting_collar: round-duct start collar - #43
Open
BenchCAD wants to merge 2 commits into
Open
[family] duct_takeoff_starting_collar: round-duct start collar#43BenchCAD wants to merge 2 commits into
BenchCAD wants to merge 2 commits into
Conversation
Rolled sheet-metal barrel + stiffening top bead + ring of base mounting tabs + optional integral butterfly damper (GreenSeam/ECCO/M&M, SMACNA). 8 params, one feature (damper). bench2 validate passes; renders inspected. Signed-off-by: BenchCAD <benchcad@users.noreply.github.com>
bench2 validateduct_takeoff_starting_collarPreviews: the |
… coincident) Codex review (gpt-5.6-sol): the blade was exactly bore-sized, so its union was a fragile coincident-face touch (silent no-op class). Give the blade a running clearance inside the bore (it's tied to the barrel by the shaft). Also correct the 'trapezoidal tabs' wording — they are modelled as rectangles. Signed-off-by: BenchCAD <benchcad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family
duct_takeoff_starting_collar—cat:hvac-ductworkReference (issue #28 — GreenSeam / ECCO / M&M start collar)
Generated — benchmark views (what the model sees)
Extremes — smallest & largest sampled instances
How it's parameterized
A rolled sheet-metal barrel with a stiffening top bead, a ring of trapezoidal base
tabs that bend flat onto the duct, and an optional integral butterfly damper (blade
damper). Only diameter varies percatalog row; tab count/width are
proportion(not dimensioned).Verification (every sampled instance — one non-degenerate solid)
bench2 validate duct_takeoff_starting_collar --seeds 5→ PASS (8 params, difficulties distinct, 15/15 unique shapes).Checklist
bench2 validatepasses locally (CI re-runs it)designs/duct_takeoff_starting_collar/(package files only — refs stay in the issue)Closes #28; DCO-signed; sources cited, nothing fabricatedSources used