Skip to content

fix(docs): keep quickstart demo restarts and approvals consistent - #209

Merged
Birfy merged 2 commits into
mainfrom
fix/quickstart-demo-races
Oct 10, 2026
Merged

Birfy merged 2 commits into
mainfrom
fix/quickstart-demo-races

Conversation

@Birfy

@Birfy Birfy commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Cancel stale asynchronous demo continuations when a new conversation starts, including restarts during run and apply playback.
  • Snapshot the planned artifact so preset edits cannot change the approved diff.
  • Add 10 deterministic JavaScript DOM/timer interaction tests and run them in docs CI.

Addresses #208 (comment) and #208 (comment).

Current integration

Forward-merged main edcd65c into head bd69a74. The refreshed website's theme, install, artifact-picker and recipe interactions are preserved. Only the original three scoped fix/test/CI files differ from that main. #211 independently resolved both earlier baseline documentation failures, so this PR no longer depends on #207.

Verification

  • Node deterministic DOM/timer suite: 10 passed on the integrated code; 6 tests fail on the unfixed implementation.
  • Focused Python documentation checks: 10 passed, including the formerly failing anchor/port-count checks.
  • node --check docs/assets/experience.js and git diff --check passed.
  • Refreshed independent review found no blocking findings; 19 additional in-memory boundary/path scenarios passed and contributor theme/install/recipe/artifact interactions were verified unchanged from main.
  • Deterministic DOM harness only; no rendered browser validation is claimed.
  • Exact-head bd69a74 CI passed all four Python 3.9/3.10/3.11/3.12 suites, wheel builds and smoke gates, plus strict MkDocs and Node regressions. Evidence: docs, Python matrix and wheel gates. Prior-head results are not this head's evidence.

Marked ready for review after independent review and exact-head CI passed. This task did not merge, release, or deploy.

@Birfy
Birfy marked this pull request as ready for review October 10, 2026 07:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T07:29:13.883782Z bd69a74 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Birfy
Birfy merged commit b787437 into main Oct 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant