Skip to content

feat: add used addresses list with address verification#3912

Closed
jstrnbrg wants to merge 0 commit into
BitBoxSwiss:masterfrom
jstrnbrg:used_addresses
Closed

feat: add used addresses list with address verification#3912
jstrnbrg wants to merge 0 commit into
BitBoxSwiss:masterfrom
jstrnbrg:used_addresses

Conversation

@jstrnbrg
Copy link
Copy Markdown
Collaborator

@jstrnbrg jstrnbrg commented Mar 4, 2026

Prerequisite: #3910

Prerequisite: #3944

@jstrnbrg jstrnbrg force-pushed the used_addresses branch 2 times, most recently from 337879a to cc95be0 Compare March 4, 2026 14:13
@jstrnbrg jstrnbrg force-pushed the used_addresses branch 3 times, most recently from cf3ebe0 to eb5ac2f Compare March 12, 2026 11:49
@jstrnbrg jstrnbrg changed the title WIP: frontend: add used addresses list with address verification frontend: add used addresses list with address verification Mar 12, 2026
@jstrnbrg jstrnbrg force-pushed the used_addresses branch 2 times, most recently from 55fba89 to e41bf2f Compare March 12, 2026 14:44
@jstrnbrg jstrnbrg requested a review from benma March 12, 2026 14:45
@jstrnbrg jstrnbrg changed the title frontend: add used addresses list with address verification feat: add used addresses list with address verification Mar 12, 2026
@jstrnbrg jstrnbrg force-pushed the used_addresses branch 3 times, most recently from eecdcc0 to 9ad2c7a Compare March 16, 2026 09:46
@shonsirsha shonsirsha self-assigned this Mar 17, 2026
@shonsirsha shonsirsha force-pushed the used_addresses branch 2 times, most recently from 27e62c2 to 6f4ca39 Compare March 18, 2026 12:33
@benma benma force-pushed the used_addresses branch 2 times, most recently from ebbef7d to cad2bd7 Compare March 26, 2026 12:26
Copy link
Copy Markdown
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff

<div className={style.segmentWrap}>
<button
type="button"
className={[style.segmentButton, value === 'receive' ? style.segmentButtonActive : ''].join(' ')}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use template/string literal and not array join anymore.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread frontends/web/src/routes/account/addresses/address-type-filter.tsx Outdated
}

.inlineLink {
color: var(--color-blue);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All color-blue should use color-primary instead

Copy link
Copy Markdown
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benma benma closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants