Repository navigation
Safe-area insets: edge to edge, shell padded by bars, cutout and keyboard - #63
Merged
Merged
Conversation
Bombatomica64
force-pushed
the
safe-area-insets
branch
from
October 12, 2026 07:59
d2bbddb to
03cc6f6
Compare
LabActivity now draws behind the system bars, the display cutout and the keyboard, and reports their insets through gpui-mobile's new host::insets_changed. The shell pads its content by them, with the title bar color underneath, and switches the bar icons between light and dark with the theme. The keyboard is now an inset that GPUI handles, as on iOS, so the SurfaceView is no longer resized when it opens. The portrait lock is gone, so landscape and the cutout can be checked. Diagnostics shows the insets. Pins gpui-mobile b2d1643 (fork main + android-host-insets). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… keyboard gpui-pre already has `PlatformWindow::insets` (safe area + IME) and `Window::fully_visible_bounds`; gpui-mobile now implements them (0dc8e30), so the shell pads by GPUI's own geometry instead of gpui-mobile's accessors. Kit's input reveal now follows the fully visible bounds (e8b2816): with the keyboard reported as an inset the viewport keeps its size, and the focused input stayed under the keyboard. Diagnostics shows the fully visible bounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Kit e8b2816 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bombatomica64
force-pushed
the
safe-area-insets
branch
from
October 12, 2026 08:46
2929f93 to
b0046fb
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bombatomica64
marked this pull request as ready for review
October 12, 2026 09:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 7 of CONTRIBUTING_IDEAS.md (safe-area insets).
c71a31a(fork main, Merge android-host-insets: safe-area and keyboard insets on the host path gpui-mobile#9; upstream candidateandroid-host-insets):host::insets_changedcarries the host's insets to the window, which implements GPUI'sPlatformWindow::insets/on_insets_changed.Window::fully_visible_bounds(),safe_area_insets()andkeyboard_height()now work on Android.e8b2816(mobile-lab, branchinput-reveal-on-focus): a focused input reveals itself when the fully visible bounds change, not only the viewport size. Without this, edge to edge left the field under the keyboard.SHORT_EDGES, transparent bars). Its insets listener reportssystemBars | displayCutoutandime. The portrait lock is removed.fully_visible_bounds(), with the title bar color underneath, and flips the bar icons with the theme.Checked on the OnePlus (Android 16, gesture navigation): portrait, landscape (cutout side padded), keyboard open with typing (field revealed above it). The light-theme bar icons were not checked.
🤖 Generated with Claude Code