Repository navigation
Merge android-host-insets: safe-area and keyboard insets on the host path - #9
Merged
Merged
Conversation
The host path had no way to pass insets in, so a host that draws behind the system bars could not tell GPUI where they are, and the Android window returned GPUI's default (zero) `PlatformWindow::insets`. `host::insets_changed` takes the bars and cutout as `SafeAreaInsets` plus the keyboard height, in physical pixels, and the render thread stores them on that host's window (or keeps them until the window opens). The window now implements `insets()` and `on_insets_changed`, so apps get the values through GPUI (`Window::fully_visible_bounds`) and GPUI refreshes the window when they change. `safe_area_insets()` and `keyboard_height()` return them too, as on iOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bombatomica64
force-pushed
the
lab-host-insets
branch
from
October 12, 2026 08:17
b2d1643 to
0dc8e30
Compare
# Conflicts: # src/android/host.rs
Bombatomica64
force-pushed
the
lab-host-insets
branch
from
October 12, 2026 08:45
0dc8e30 to
c71a31a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
android-host-insets(based on upstreammain, the branch to propose upstream) into forkmain, so the lab can pin it.host::insets_changed(host, SafeAreaInsets, ime): the host reports the system bars, cutout and keyboard in physical px. The render thread stores them on that host's window, or keeps them until the window opens.AndroidPlatformWindowimplements GPUI'sinsets()/on_insets_changed, soWindow::fully_visible_bounds()works and GPUI refreshes on change.gpui_mobile::safe_area_insets()andkeyboard_height()return them too, as on iOS.The only conflict was in
host.rs, next toconfiguration_changed(longbridge#30 here); I kept both sides.Lab: Bombatomica64/Gpui-android#63.
🤖 Generated with Claude Code