Repository navigation
fix(smoke): report the failed range's recorded reason - #2488
Merged
Merged
Conversation
When the post-deploy smoke's range failed, the smoke printed only 'range reached terminal status failed', and the range's recorded failure reason lived only in the database, invisible from CI without cluster access. The smoke now appends that reason, bounded and sanitized, read through a new engine.services accessor (get_range_failure_reason_by_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the post-deploy smoke's range fails, the smoke prints only
range reached terminal status failed (request_id=...). The range's recorded failure reason lives only in the database, so diagnosing a failed smoke from CI needs in-cluster access (EKS API is private and pod logs are not shipped to CloudWatch).Change
The smoke appends the range's recorded failure reason, bounded to 500 characters and sanitized, read through a new
engine.services.get_range_failure_reason_by_requestaccessor (same shape as the existing by-request accessors).Verification
tests/mission_control/test_run_post_deploy_smoke_command.pypasses, including a new case that records a failure reason on a real range row and asserts it reaches the smoke's error.