Repository navigation
feat(runtime)!: report worker callback outcome instead of run state - #34
Merged
Merged
Conversation
BREAKING CHANGE: POST /runs/:runId/effects/:effectId/:attempt/:action returns { status, cancelRequested } instead of the run state. createLooms().workerCallback and the HTTP client return the same shape. Heartbeats may carry details that the next attempt's task includes. failEffect and worker fail callbacks can mark an attempt non-retryable or set retryAfterMs.
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks done
Co-authored-by: Cursor <cursoragent@cursor.com>
The retry is scheduled from the wake's clock, which is read before the event timestamp, so comparing against the event could fail by a millisecond. The assertion also no longer skips when the payload is missing. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ status: 'accepted' | 'stale' | 'cancelled', cancelRequested }so an attempt that has already been dispatched can learn it should stop. The host no longer sends the run state.failEffectand workerfailcallbacks can end the retry budget withnonRetryable, or wait at leastretryAfterMswithout shortening the policy backoff.details. The latest details stay on the execution record across retries and are included on the next worker task.Test plan
bun x tsc -p packages/core/tsconfig.build.json --noEmitbun x tsc -p packages/runtime/tsconfig.build.json --noEmitbun x tsc -p packages/client/tsconfig.build.json --noEmitbun test srcinpackages/core,packages/runtime, andpackages/clientbun x oxlinton the changed sources with--deny-warningsbun run verifyfor the full workspace (not run in this change; package checks above cover the touched packages)Made with Cursor