fix: typed error taxonomy, Redis degraded mode, analytics UX states & mobile responsiveness#754
Merged
Conversation
…ebux#607 Calebux#615 Calebux#632 Calebux#637) Issue Calebux#632 – typed error taxonomy: - Add ExternalDependencyError (HTTP 502) to backend/src/errors/index.ts - Add backend/tests/error-taxonomy.test.ts asserting HTTP response shapes for every domain error class Issue Calebux#637 – harden Redis outage behavior: - Add isDegraded() to RateLimitRedisStore; exposed in getHealthStatus() - Extend RateLimiterFactory.getStoreStatus() with a degraded flag so health endpoints can surface memory-fallback mode - Add outage scenario tests in redis-store.test.ts (connect/disconnect transitions, fallback via createRedisStore) Issue Calebux#607 – dashboard loading/empty/error states: - Add client/app/dashboard/analytics/loading.tsx (skeleton layout matching page structure) - Add client/app/dashboard/analytics/error.tsx (Next.js error boundary with retry button) - Add empty state to analytics route when active_subscriptions === 0 - Error state in analytics route now has a retry button (calls fetchAnalytics again) Issue Calebux#615 – responsive analytics pages: - Stats grid: 1 col on mobile, 3 col on sm+ - Charts: wrapped in overflow-x-auto with min-width guard; reduced height on mobile - Category legend: 1 col mobile, 2 col sm+; labels truncated to prevent overflow - Top subscriptions: horizontal-scroll wrapper, name truncation, flex-shrink on price column - Budget row: flex-wrap so label and amount stack on narrow screens Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7 tasks
|
@Samuel1-ona Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExternalDependencyError(HTTP 502) for Redis/email/payment failures, and a full test suite (error-taxonomy.test.ts) asserting every domain error class maps to the correct HTTP response shape via the global error handler.isDegraded()toRateLimitRedisStore, adegradedflag ingetHealthStatus()andRateLimiterFactory.getStoreStatus(), and comprehensive outage scenario tests (connect/disconnect transitions, memory-fallback, cold-start).loading.tsx(skeleton) anderror.tsx(error boundary with retry) forclient/app/dashboard/analytics/; adds an empty state when no subscriptions exist; error state now has a functional retry button.overflow-x-autowith min-width guard, category legend switches to single column on small screens, top subscriptions table gets horizontal scroll + name truncation, budget row flex-wraps.Test plan
backend/tests/error-taxonomy.test.ts— 16 new tests, all passingbackend/tests/redis-store.test.ts— 22 tests (7 new outage scenarios), all passingCloses #607
Closes #615
Closes #632
Closes #637
🤖 Generated with Claude Code