Log the server's error when registration is refused - #23
Open
letalvoj wants to merge 1 commit into
Open
Conversation
A refused registration is currently silent. RegisterResponse carries the reason in Error — "invalid key: API key does not exist" for a bad auth key — but do_register() only reads Node, which a successful response omits too, so nothing tells the two apart. The first visible symptom is therefore "node not found" from the MapRequest that follows, reported by a different function and pointing at peer fetching rather than at the key: E ml_coord: RegisterResponse error: invalid key: API key does not exist (new) E ml_coord: MapResponse JSON parse failed near: node not found (was all) Tested against controlplane.tailscale.com on an ESP32-S3, with an unknown machine key and an invalid auth key.
letalvoj
force-pushed
the
fix/log-registration-error
branch
from
July 30, 2026 13:36
d5691b2 to
4cc3dde
Compare
fudio101
referenced
this pull request
in fugo101/microlink
Aug 14, 2026
Absorb upstream #23: log the server's error when registration is refused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refused registration is currently silent. RegisterResponse carries the reason in Error — "invalid key: API key does not exist" for a bad auth key — but do_register() only reads Node, which a successful response omits too, so nothing tells the two apart.
The first visible symptom is therefore "node not found" from the MapRequest that follows, reported by a different function and pointing at peer fetching rather than at the key:
E ml_coord: RegisterResponse error: invalid key: API key does not exist (new)
E ml_coord: MapResponse JSON parse failed near: node not found (was all)
Tested against controlplane.tailscale.com on an ESP32-S3, with an unknown machine key and an invalid auth key.