Absorb upstream #23: log the server's error when registration is refused - #6
Merged
Conversation
A refused registration is currently silent. RegisterResponse carries the reason in Error — "invalid key: API key does not exist" for a bad auth key — but do_register() only reads Node, which a successful response omits too, so nothing tells the two apart. The first visible symptom is therefore "node not found" from the MapRequest that follows, reported by a different function and pointing at peer fetching rather than at the key: E ml_coord: RegisterResponse error: invalid key: API key does not exist (new) E ml_coord: MapResponse JSON parse failed near: node not found (was all) Tested against controlplane.tailscale.com on an ESP32-S3, with an unknown machine key and an invalid auth key. (cherry picked from commit 4cc3dde) Upstream-PR: CamM2325#23
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks
4cc3ddedfrom CamM2325/microlink#23 by @letalvoj, unchanged aside from a provenance trailer. Author attribution preserved viagit cherry-pick -x.Why we're absorbing this ourselves: upstream has had zero maintainer activity (no comments, no reviews) on any open PR since the last commit on 2026-03-17.
What it fixes: a refused registration is currently silent.
RegisterResponsecarries the reason inError(e.g. "invalid key: API key does not exist" for a bad auth key), butdo_register()only readsNode, which a successful response omits too — nothing distinguishes the two. The first visible symptom today is a misleadingMapResponse ... node not foundfrom the next request, pointing at peer fetching rather than the actual cause. This logs the real error.Applied cleanly (
git apply --check) against our diverged fork. Built clean forlilygo-t-display-s3(ESP-IDF 6.0.1) in the downstream ZenClock project.