feat(sdks): fill verified registry metadata for 25 Algorand, Filecoin and Somnia SDK offers - #3231
Conversation
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The PR is narrow to references/offers/sdks.csv and only fills registry/repository metadata columns for existing SDK rows. CSV parsing stays stable at 18 columns/158 rows, required validation passed, and the reviewer-owned current-cycle link-check run 32983721214 completed successfully with 45/45 successful links and 0 errors/timeouts/unknown/unsupported.
Findings: None.
Confidence: HIGH
|
Hi @eugene17kotov - this PR is stale, required CI is passing, and I don't see a blocking review. Could you please review when you have a chance? |
… and Somnia SDK offers Rebased onto current main after upstream added new SDK rows. The conflict was line offsets only: no cell this branch fills has been given a value upstream, verified by comparing both revisions cell by cell.
2cd0200 to
80a9503
Compare
|
Flagging a compliance problem with this PR that I found after it was approved, rather than letting it merge unmentioned. The
This PR modifies those columns manually. I did not know that paragraph existed when I opened this in August, and the review process did not surface it — but that does not make the edit compliant. I am not asking for an exception. #3574 now puts the question directly to the maintainers: run the automation, drop the reservation, or drop the columns. If the reservation stands, please close this PR. If it is lifted, the change is ready as it is. Every value here is sourced from the row's own action-button link — the package's registry entry or its GitHub repository — and the branch has been rebuilt on current |
Fills
latestKnownVersion,latestKnownReleaseDate,maintainerandlicenseon 25 SDK rows referenced by the Algorand, Filecoin and Somnia listings. 96 previously empty cells, 25 rows, one file.These four columns are objectively checkable — they come from package registries and the projects' own repositories, so nothing here rests on vendor marketing copy.
abitypealgokit-avm-vscode-debuggeralgokit-clialgokit-client-generator-pyalgokit-client-generator-tsalgokit-utils-pyalgokit-utils-tsalgorand-go-sdkalgorand-java-sdkalgorand-javascript-sdkalgorand-python-sdkalloyape-frameworketh-abieth-accountethereumjsgo-ethereumoxsafe-api-kitsafe-protocol-kitsomnia-data-streams-sdksynapse-sdktevmviemweb3jWhere each value came from. Versions and dates are the latest GitHub release for standalone repositories. For the three packages published out of a monorepo the repo tag does not identify the package, so the npm registry was used instead:
safe-api-kitandsafe-protocol-kitsit under oner71monorepo tag, andsomnia-data-streams-sdkpublishes as@somnia-chain/streamswith no GitHub releases at all. Licenses are GitHub's detected SPDX identifier, cross-checked on npm where GitHub returnedNOASSERTION— that is howviem(MIT),synapse-sdk(MIT / Apache-2.0) andweb3j(Apache-2.0, itsLICENSEis the Apache 2.0 text verbatim) were resolved. Maintainers are the GitHub organisation's own published display name, which is why a few differ from theproviderbrand in the same row —Safeis maintained bySafe Labs GmbH, the AlgoKit tooling by theAlgorand Foundationrather thanAlgorand.Formatting follows the rows that already carry real values. Versions are bare semver with no
vprefix, matching four of the five populated examples in the file. Dates are ISOYYYY-MM-DD. Licenses are SPDX identifiers, with the existingMIT / Apache-2.0form reused for the dual-licensed row.Left empty rather than guessed. Three gaps I could not close from a source I actually read:
go-ethereummaintainer — theethereumorganisation publishes no display name and the README states none, so there was nothing to cite.ethereumjsversion, date and license — a monorepo whose packages carry different licences (packages/vmis MPL-2.0), with no rootLICENSEand no single release version. Its latest release tag is@ethereumjs/vm@10.1.3, which describes one package rather than the row.iso-filecoinandnethereumare untouched — neither has a repository link inactionButtonsto verify against.I would rather leave a cell empty than fill it with something that reads as verified and is not.
Note on
TBD. Most rows in this file carryTBDin these four columns — 120 of them for version and date. I have not touched those, since replacing a placeholder is a different change from filling an empty cell and would balloon the diff past the size limit. If you would like the same treatment applied to theTBDrows I am happy to do it in follow-up PRs, batched to stay inside the 100-line / 200-cell limit.validate_csv.pyfrom thejson-toolsbranch:All checks passed.No links were added or changed.Reward address:
0x1589423BeCC3F87EA9406155EaF4D5E04C34Dcf1(USDC/USDT, Ethereum mainnet)